[GitHub] [incubator-doris] morningman edited a comment on pull request #6702: [Optimize] Use compact mode to send query plan thrift data structure.

[GitBox <gi...@apache.org>]

morningman edited a comment on pull request #6702:
URL: https://github.com/apache/incubator-doris/pull/6702#issuecomment-925910461


   > > > > > according to the request size？
   > > > > 
   > > > > 
   > > > > The key point is how to determine the threshold of the size...
   > > > 
   > > > 
   > > > I think that it is better to use threshold of the size than to use use_compact_thrift_rpc as a config.
   > > 
   > > 
   > > You mean use size as config and using a big or small value as default?
   > 
   > yeah, because the request size is different with each other, it is not flexible for users to just simply turn on or turn off the use_compact_thrift_rpc config
   
   Sounds reasonable, since there is no other better idea.
   But we can not get thrift data size before serialization. So we can't use size as threshold now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org