You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2016/02/07 09:10:37 UTC
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/11110
[SPARK-13200][MLLIB][TRIVIAL] Remove rounding on integer in MFDataGenerator
Trivial removal of rounding call on an integer. Was causing an warning in Scala 2.11
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/spark SPARK-13200-remove-unecessary-rounding-in-mfdata
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11110
----
commit ec2e8f723b1bb9cbb603c0c85b97a2b89dc7c066
Author: Holden Karau <ho...@us.ibm.com>
Date: 2016-02-07T08:07:15Z
Remove rounding on integer in MFDataGenerator
commit 5418c18f1574dcd11812f8101cc5bcf477394f54
Author: Holden Karau <ho...@us.ibm.com>
Date: 2016-02-07T08:08:12Z
remove type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11110#issuecomment-180981168
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11110#issuecomment-180983909
I'm going to close this and group it together with some other deprecation fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11110#issuecomment-180974841
**[Test build #50894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50894/consoleFull)** for PR 11110 at commit [`5418c18`](https://github.com/apache/spark/commit/5418c18f1574dcd11812f8101cc5bcf477394f54).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11110#issuecomment-181015193
OK sure, the change looks correct to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11110#issuecomment-180981169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50894/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11110#issuecomment-180980991
**[Test build #50894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50894/consoleFull)** for PR 11110 at commit [`5418c18`](https://github.com/apache/spark/commit/5418c18f1574dcd11812f8101cc5bcf477394f54).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13200][MLLIB][TRIVIAL] Remove rounding ...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk closed the pull request at:
https://github.com/apache/spark/pull/11110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org