[GitHub] [sling-org-apache-sling-scripting-sightly] bdelacretaz commented on a change in pull request #11: SLING-9989: migrate date formating to java.time API

[GitBox <gi...@apache.org>]

bdelacretaz commented on a change in pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r673787887



##########
File path: src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##########
@@ -99,47 +100,26 @@ public void testDateFormatWithZoneName() {
     }
 
     @Test
-    public void testDateFormatWithEscapedCharactersJdk8() {
-        assumeJdk8();
-        assertDate("01 December '18 12:00 AM; day in year: 335; week in year: 49",
-            "dd MMMM ''yy hh:mm a; 'day in year': D; 'week in year': w",
-            "UTC",
-            null);
-    }
-
-    @Test
-    public void testDateFormatWithEscapedCharactersJdk11OrNewer() {
-        assumeJdk11OrNewer();
+    @Ignore("ambiguous results depending on the jdk version and implementation used")

Review comment:
       If the tests run reliably from Maven I'm fine, and as you mention a comment for IDEs is good enough. But I don't think the tests should be @ignored by default, my view is that Maven must run all tests reliably, and IDEs come second.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org