You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/03 14:56:32 UTC

[GitHub] [tvm] masahi commented on pull request #7391: [ONNX] Add CumSum operator to ONNX frontend

masahi commented on pull request #7391:
URL: https://github.com/apache/tvm/pull/7391#issuecomment-772568769


   `exclusive` can be easily supported by `cumsum(data) - data`. Similarly, I expect `reverse` can also be supported by composing with `reverse` op. But I think this attribute is weird (why would anyone one want to do reverse cumsum), so it might not be worth it.
   
   It's strange ONNX `Cumsum` doesn't have output dtype attribute. Without it, there could be overflow issues for int32 input. Also it wouldn't work for boolean input, which is a common input to cumsum. I guess they expect casting to be done by users beforehand.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org