[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8219: [WIP] Build better support for schema permissions

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #8219: [WIP] Build better support for schema permissions
URL: https://github.com/apache/incubator-superset/pull/8219#discussion_r325194493
 
 

 ##########
 File path: superset/security.py
 ##########
 @@ -376,19 +380,47 @@ def rejected_tables(self, sql: str, database: "Database", schema: str) -> List[s
             if not self._datasource_access_by_fullname(database, t, schema)
         ]
 
-    def _user_datasource_perms(self) -> Set[str]:
-        """
-        Return the set of FAB permission view-menu names the user can access.
+    def get_public_role(self):
 
 Review comment:
   Add return type

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org