[GitHub] [karaf] grgrzybek commented on a change in pull request #1489: [KARAF-7389] Prevent two threads (feature installer, CM Event Dispatc…

[GitBox <gi...@apache.org>]

grgrzybek commented on a change in pull request #1489:
URL: https://github.com/apache/karaf/pull/1489#discussion_r802607889



##########
File path: features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java
##########
@@ -137,10 +137,10 @@ public void installFeatureConfigs(Feature feature) throws IOException, InvalidSy
                     cfg = createConfiguration(configAdmin, cid);
                     cfgProps.put(CONFIG_KEY, cid.pid);
                     properties.put(CONFIG_KEY, cid.pid);
+                    cfg.update(cfgProps);

Review comment:
       I moved the update up, so it's updated _without_ `felix.fileinstall.filename` property at this stage - this ensures that fileinstall (handling `CM_UPDATED`) won't read+write the file being written at the same time with `updateStorage()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org