[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22364: Improve DistSQL DROP DB_DISCOVERY RULE

[GitBox <gi...@apache.org>]

RaigorJiang commented on code in PR #22364:
URL: https://github.com/apache/shardingsphere/pull/22364#discussion_r1030988520


##########
features/db-discovery/distsql/handler/src/test/java/org/apache/shardingsphere/dbdiscovery/distsql/handler/update/DropDatabaseDiscoveryRuleStatementUpdaterTest.java:
##########
@@ -106,7 +107,8 @@ public void assertUpdateCurrentRuleConfiguration() {
         DatabaseDiscoveryRuleConfiguration databaseDiscoveryRuleConfig = createCurrentRuleConfiguration();
         updater.updateCurrentRuleConfiguration(createSQLStatement(), databaseDiscoveryRuleConfig);
         assertTrue(databaseDiscoveryRuleConfig.getDataSources().isEmpty());
-        assertThat(databaseDiscoveryRuleConfig.getDiscoveryTypes().size(), is(1));
+        assertThat(databaseDiscoveryRuleConfig.getDiscoveryTypes().size(), is(0));

Review Comment:
   `assertTrue(xxxCollection.isEmpty());`  is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org