[jira] [Commented] (METRON-1347) Indexing Topology should fail tuples without a source.type

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317044#comment-16317044 ] 

ASF GitHub Bot commented on METRON-1347:
----------------------------------------

Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/863#discussion_r160250862
  
    --- Diff: metron-platform/metron-indexing/README.md ---
    @@ -15,6 +15,12 @@ Indices are written in batch and the batch size and batch timeout are specified
     [Sensor Indexing Configuration](#sensor-indexing-configuration) via the `batchSize` and `batchTimeout` parameters.
     These configs are variable by sensor type.
     
    +## Minimal Assumptions for Message Structure
    +
    +At minimum, a message should have a `sensor.type` field.
    --- End diff --
    
    sensor.type - did you mean source.type?


> Indexing Topology should fail tuples without a source.type
> ----------------------------------------------------------
>
>                 Key: METRON-1347
>                 URL: https://issues.apache.org/jira/browse/METRON-1347
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Casey Stella
>
> If you are sending data into metron indexing without a source.type, which would only happen if you're bypassing our previous topologies, we cannot configure how we write to the indices, so the message should be explicitly failed and reported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)