You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Bastian Hofmann <ba...@googlemail.com> on 2011/08/25 14:02:06 UTC
Review Request: Remove Quirks Mode PHP Implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1655/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
See https://issues.apache.org/jira/browse/SHINDIG-1595 or https://issues.apache.org/jira/browse/SHINDIG-1504
Diffs
-----
/trunk/php/src/gadgets/Gadget.php 1161444
/trunk/php/src/gadgets/GadgetSpec.php 1161444
/trunk/php/src/gadgets/GadgetSpecParser.php 1161444
/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php 1161444
/trunk/php/test/gadgets/GadgetHtmlRendererTest.php 1161444
/trunk/php/test/gadgets/GadgetSpecParserTest.php 1161444
Diff: https://reviews.apache.org/r/1655/diff
Testing
-------
Thanks,
Bastian
Re: Review Request: Remove Quirks Mode PHP Implementation
Posted by Bastian Hofmann <ba...@googlemail.com>.
> On 2011-08-25 14:21:43, Henry Saputra wrote:
> > /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php, line 44
> > <https://reviews.apache.org/r/1655/diff/1/?file=35515#file35515line44>
> >
> > Is this to check if view name requested is "quirks"?
No, in the PHP implementation so far you could add a quirks attribute to a content block to specify that this content block should be rendered in quirks mode, otherwise the gadget would be rendered with the html4 strict doctype by default:
<Content type="html" quirks="true" views="canvas">
...
</Content>
I decided to leave this feature for backwards compatibility.
- Bastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1655/#review1640
-----------------------------------------------------------
On 2011-08-25 12:02:06, Bastian Hofmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1655/
> -----------------------------------------------------------
>
> (Updated 2011-08-25 12:02:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1595 or https://issues.apache.org/jira/browse/SHINDIG-1504
>
>
> Diffs
> -----
>
> /trunk/php/src/gadgets/Gadget.php 1161444
> /trunk/php/src/gadgets/GadgetSpec.php 1161444
> /trunk/php/src/gadgets/GadgetSpecParser.php 1161444
> /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php 1161444
> /trunk/php/test/gadgets/GadgetHtmlRendererTest.php 1161444
> /trunk/php/test/gadgets/GadgetSpecParserTest.php 1161444
>
> Diff: https://reviews.apache.org/r/1655/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian
>
>
Re: Review Request: Remove Quirks Mode PHP Implementation
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1655/#review1640
-----------------------------------------------------------
/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php
<https://reviews.apache.org/r/1655/#comment3680>
Is this to check if view name requested is "quirks"?
- Henry
On 2011-08-25 12:02:06, Bastian Hofmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1655/
> -----------------------------------------------------------
>
> (Updated 2011-08-25 12:02:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1595 or https://issues.apache.org/jira/browse/SHINDIG-1504
>
>
> Diffs
> -----
>
> /trunk/php/src/gadgets/Gadget.php 1161444
> /trunk/php/src/gadgets/GadgetSpec.php 1161444
> /trunk/php/src/gadgets/GadgetSpecParser.php 1161444
> /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php 1161444
> /trunk/php/test/gadgets/GadgetHtmlRendererTest.php 1161444
> /trunk/php/test/gadgets/GadgetSpecParserTest.php 1161444
>
> Diff: https://reviews.apache.org/r/1655/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian
>
>
Re: Review Request: Remove Quirks Mode PHP Implementation
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1655/#review1648
-----------------------------------------------------------
Ship it!
+1
- Henry
On 2011-08-25 12:02:06, Bastian Hofmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1655/
> -----------------------------------------------------------
>
> (Updated 2011-08-25 12:02:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1595 or https://issues.apache.org/jira/browse/SHINDIG-1504
>
>
> Diffs
> -----
>
> /trunk/php/src/gadgets/Gadget.php 1161444
> /trunk/php/src/gadgets/GadgetSpec.php 1161444
> /trunk/php/src/gadgets/GadgetSpecParser.php 1161444
> /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php 1161444
> /trunk/php/test/gadgets/GadgetHtmlRendererTest.php 1161444
> /trunk/php/test/gadgets/GadgetSpecParserTest.php 1161444
>
> Diff: https://reviews.apache.org/r/1655/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian
>
>
Re: Review Request: Remove Quirks Mode PHP Implementation
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1655/#review1659
-----------------------------------------------------------
Ship it!
lgtm
- Paul
On 2011-08-25 12:02:06, Bastian Hofmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1655/
> -----------------------------------------------------------
>
> (Updated 2011-08-25 12:02:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1595 or https://issues.apache.org/jira/browse/SHINDIG-1504
>
>
> Diffs
> -----
>
> /trunk/php/src/gadgets/Gadget.php 1161444
> /trunk/php/src/gadgets/GadgetSpec.php 1161444
> /trunk/php/src/gadgets/GadgetSpecParser.php 1161444
> /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php 1161444
> /trunk/php/test/gadgets/GadgetHtmlRendererTest.php 1161444
> /trunk/php/test/gadgets/GadgetSpecParserTest.php 1161444
>
> Diff: https://reviews.apache.org/r/1655/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian
>
>