You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2019/07/28 18:47:51 UTC
[whimsy] branch master updated: remove PMC notice requirement from
non-PMCs
This is an automated email from the ASF dual-hosted git repository.
rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 22e4a9b remove PMC notice requirement from non-PMCs
22e4a9b is described below
commit 22e4a9b26463fb06fc17a7df1b1db0b14a0d10c8
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Sun Jul 28 14:47:33 2019 -0400
remove PMC notice requirement from non-PMCs
---
www/roster/views/nonpmc/add.js.rb | 11 +----------
www/roster/views/nonpmc/mod.js.rb | 14 +-------------
2 files changed, 2 insertions(+), 23 deletions(-)
diff --git a/www/roster/views/nonpmc/add.js.rb b/www/roster/views/nonpmc/add.js.rb
index 320bf65..e6bae68 100644
--- a/www/roster/views/nonpmc/add.js.rb
+++ b/www/roster/views/nonpmc/add.js.rb
@@ -53,15 +53,6 @@ class NonPMCAdd < Vue
_CommitterSearch add: self.add,
exclude: @@project.roster.keys().
concat(@people.map {|person| person.id})
-
- _p do
- _label do
- _input type: 'checkbox', checked: @notice_elapsed
- _a '72 hour board@ NOTICE',
- href: 'https://www.apache.org/dev/pmc.html#notice_period'
- _span ' period elapsed?'
- end
- end
end
end
@@ -79,7 +70,7 @@ class NonPMCAdd < Vue
_button.btn.btn_primary 'Add to Committee', onClick: self.post,
data_action: 'add pmc info commit',
- disabled: (@people.empty? or not @notice_elapsed)
+ disabled: @people.empty?
end
end
end
diff --git a/www/roster/views/nonpmc/mod.js.rb b/www/roster/views/nonpmc/mod.js.rb
index 73692f5..e1384da 100644
--- a/www/roster/views/nonpmc/mod.js.rb
+++ b/www/roster/views/nonpmc/mod.js.rb
@@ -39,18 +39,6 @@ class NonPMCMod < Vue
end
end
end
-
- # add to Committee button is only shown if every person is not on the Committee
- if @people.all? {|person| !@@project.members.include? person.id}
- _p do
- _label do
- _input type: 'checkbox', checked: @notice_elapsed
- _a '72 hour board@ NOTICE',
- href: 'https://www.apache.org/dev/pmc.html#notice_period'
- _span ' period elapsed?'
- end
- end
- end
end
_div.modal_footer do
@@ -63,7 +51,7 @@ class NonPMCMod < Vue
if @people.all? {|person| !@@project.members.include? person.id}
_button.btn.btn_primary "Add to Committee",
data_action: 'add pmc info',
- onClick: self.post, disabled: (@people.empty? or not @notice_elapsed)
+ onClick: self.post, disabled: @people.empty?
end
# remove from all relevant locations