You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "zhongyujiang (via GitHub)" <gi...@apache.org> on 2023/07/21 15:19:55 UTC
[GitHub] [iceberg] zhongyujiang opened a new pull request, #8128: Core, API: Add non-nullable constraint checks to support making optional columns…
zhongyujiang opened a new pull request, #8128:
URL: https://github.com/apache/iceberg/pull/8128
… required.
This adds support for adding new required columns and making optional columns required to `SchemaUpdate` (without calling `allowIncompatibleChanges`). This is inspired by this [comment](https://github.com/apache/iceberg/pull/5007#issuecomment-1154241027).
When applying schema changes to the table, it will check table's metadata to see if there are any null values and allow the change after verifying that compatibility is sure not broken, otherwise throws a validation exception.
By default this will check all files referenced(including files marked as `deleted`) by all live snapshots in the table,because deleted files may also be read using the new schema (e.g. CDC read), this also provides a method `validateLiveDataOnly` to allow validate live data only when performing compatibility checks, which can be used when the user confirms that the deleted data does not need to be queried.
@szehon-ho @rdblue Can you please help review this ? Thansks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, API: Add non-nullable constraint checks to support making optional columns… [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8128:
URL: https://github.com/apache/iceberg/pull/8128#issuecomment-2351239444
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, API: Add non-nullable constraint checks to support making optional columns… [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8128: Core, API: Add non-nullable constraint checks to support making optional columns…
URL: https://github.com/apache/iceberg/pull/8128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, API: Add non-nullable constraint checks to support making optional columns… [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8128:
URL: https://github.com/apache/iceberg/pull/8128#issuecomment-2336490508
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org