You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/26 15:24:41 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #11426: Line chart series limit doesn't show correct result on chart
zuzana-vej opened a new issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426
The Series Limit dropdown in Superset Explore allows to limit the number of series when there are too many. However, it looks like the specified limit is not accurate.
The query generated from the chart looks correct, and running the query in SQL Lab gives the expected result - if limit is 5 items, all 5 items are showing up there. So the problem seem to be with the chart.
### Expected results
Series Limit = 10 shows 10 results
### Actual results
Setting Series Limit = 10 gave me 9 results when 10 series actually existed. In another case series limit = 10 gave 14 results. Note I believe when using with time shift, the time shifted lines might not be counting to the total limit (regardless of how this case is actually handled, current behavior has issue).
#### Screenshots
Example 1: Returned 14 series, while limit is set to 10.
Example 2: Returned 6 series while limit it set to 5.
Example 3: Even when removing time shift comparisons, the result is 2 series, while limit is set to 5.
#### How to reproduce the bug
1. Go to Chart Explore, Line chart
2. Click on Series and set the limit
3. See how many results you actually get
### Environment
(please complete the following information):
- superset version: `master`
### Checklist
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] anilvpatel21 edited a comment on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
anilvpatel21 edited a comment on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-742984456
@zuzana-vej I am also getting the same issue, did you find any solution to workaround. SQL is not building up any sub query when I set a limit to 5 or 10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc removed a comment on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-716740627
Hey Zuzana, I just tested on latest master, it looks alright to me. would you mind confirming?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] anilvpatel21 commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
anilvpatel21 commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-742984456
@zuzana-vej I am also getting the same issue, did you find any solution to work around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-716740627
Hey Zuzana, I just tested on latest master, it looks alright to me. would you mind confirming?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-716621117
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-718853067
@mistercrunch SQL looks correct (limit is set up) and taking that SQL and running it in SQL Lab gives the intended result (e.g. there are the 5 unique items if limit is set to 5).
We will look into it a bit more to troubleshoot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-743324235
Yes, we determined it's not a bug. Here is when we found out of was happening and how to prevent it:
When there is no sort metric, so if you run query with LIMIT 10, it can limit kind of randomly. If you add "advanced analytics" with offset, it basically results in 2 queries and since there is no sort metric and they are limited to 10 (or whatever you use) the returned results could mismatch so you might see more than 10 values in the final chart.
Easiest way to validate once you build your chart is to get the query and try to run it in SQL Lab. When we tried it without the sort metric, we could get different results different times the query is run. Adding the sort metric should fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-718379540
I'd be curious to see the generated SQL here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-716750664
Okay.. I will check again. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-716750264
Zuzana, I just tested on latest master, and it looks alright. can you double check? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-716853190
@zuzana-vej To help narrow this down, can you test this without time shift to make sure that's not causing trouble?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11426: Line chart series limit doesn't show correct result on chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11426:
URL: https://github.com/apache/incubator-superset/issues/11426#issuecomment-718326832
Yes I tested both with / without time series.And both have issue. Just tested on latest master now.
Here is an example of limit to 5 series:
<img width="809" alt="Screen Shot 2020-10-28 at 7 53 04 PM" src="https://user-images.githubusercontent.com/61221714/97519943-660e6280-1957-11eb-9405-f4a5b5ef3957.png">
Here is the same chart without the limit:
<img width="809" alt="Screen Shot 2020-10-28 at 7 53 18 PM" src="https://user-images.githubusercontent.com/61221714/97519951-6870bc80-1957-11eb-8b8d-de375a167efa.png">
cc: @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org