You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/10/27 20:21:34 UTC
[GitHub] tajo pull request: TAJO-1141: Refactor the packages hierarchy of t...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/217
TAJO-1141: Refactor the packages hierarchy of tajo-client.
See https://issues.apache.org/jira/browse/TAJO-1141. This patch depends on TAJO-1140.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit fca180a66c7aa118e5ce12dc434206c782b86862
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-10-27T07:46:22Z
TAJO-1140: Separate TajoClient into fine grained parts.
commit 32e547c97b1c338c51710ea984bf4fcf54f61a59
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-10-27T19:20:04Z
TAJO-1141: Refactor the packages hierarchy of tajo-client.
commit d3e5e950f76d9c0eb0a42fc956166ea859d44953
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-10-27T19:20:19Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1141
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1141: Refactor the packages hierarchy of t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1141: Refactor the packages hierarchy of t...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/217#issuecomment-61221535
+1
The motivation is reasonable and the patch looks nice to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1141: Refactor the packages hierarchy of t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/217#issuecomment-60807676
Thanks for the comment. I fixed the test failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1141: Refactor the packages hierarchy of t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/217#issuecomment-60716250
rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1141: Refactor the packages hierarchy of t...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/217#issuecomment-60719906
Hi @hyunsik
I found a bug during compiling as follows:
{code:xml}
Tests run: 14, Failures: 0, Errors: 14, Skipped: 0, Time elapsed: 0.062 sec <<< FAILURE! - in org.apache.tajo.cli.tsql.TestTajoCli
testParseParam(org.apache.tajo.cli.tsql.TestTajoCli) Time elapsed: 0.051 sec <<< ERROR!
java.lang.RuntimeException: java.lang.ClassNotFoundException: org.apache.tajo.cli.DefaultTajoCliOutputFormatter
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:169)
at org.apache.tajo.OverridableConf.getClass(OverridableConf.java:220)
at org.apache.tajo.cli.tsql.TajoCli.initFormatter(TajoCli.java:309)
at org.apache.tajo.cli.tsql.TajoCli.<init>(TajoCli.java:187)
at org.apache.tajo.cli.tsql.TestTajoCli.setUp(TestTajoCli.java:77)
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---