You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by mo...@apache.org on 2019/04/23 02:17:31 UTC

[incubator-weex] branch master updated: [iOS] destroy vnode first , then destroy jsobject

This is an automated email from the ASF dual-hosted git repository.

moshen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
     new 48e6437  [iOS] destroy vnode first ,then destroy jsobject
     new 674f4b5  Merge pull request #2349 from jianhan-he/master
48e6437 is described below

commit 48e64372ffaa450fb2536fdfc2dbbe5e0cb8cba4
Author: linghe.lh <li...@alibaba-inc.com>
AuthorDate: Tue Apr 23 10:08:33 2019 +0800

    [iOS] destroy vnode first ,then destroy jsobject
---
 ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index ff568b6..be90637 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -726,13 +726,17 @@ _Pragma("clang diagnostic pop") \
         if (_dataRenderHandler) {
             WXPerformBlockOnComponentThread(^{
                 [_dataRenderHandler destroyDataRenderInstance:instance];
+                WXPerformBlockOnBridgeThread(^{
+                    [self callJSMethod:@"destroyInstance" args:@[instance]];
+                });
             });
         }
         else {
             WXLogError(@"No data render handler found!");
         }
+    } else {
+        [self callJSMethod:@"destroyInstance" args:@[instance]];
     }
-    [self callJSMethod:@"destroyInstance" args:@[instance]];
 }
 
 - (void)forceGarbageCollection