You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2019/06/07 17:21:44 UTC
Review Request 70811: Fixed compilation error on Mac OS.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
Repository: mesos
Description
-------
This patch adds missing switch case to fix compilation error introduced
in `bc5a57122635`.
Diffs
-----
src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
Diff: https://reviews.apache.org/r/70811/diff/1/
Testing
-------
internal CI
Thanks,
Andrei Budnik
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215768
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70811]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 7, 2019, 5:21 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 5:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215797
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On June 7, 2019, 5:21 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 5:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/2/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215801
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On June 7, 2019, 7:21 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 7:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/2/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215755
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On June 7, 2019, 10:21 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 10:21 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Июнь 7, 2019, 6:55 п.п., Benjamin Bannier wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Line 508 (original), 509 (patched)
> > <https://reviews.apache.org/r/70811/diff/1/?file=2148200#file2148200line510>
> >
> > For non-`__linux-_` cases this silently drops any configuration. Why wouldn't we return an error in that case instead?
This cpp-module has inconsistencies with handling of Linux/non-Linux cases. For example, `prepareMounts` and `maskPath` are simply no-ops on non-Linux platforms.
This patch fixes compilation error. Fixing the whole inconsistency issue in a single place is not a goal here.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215759
-----------------------------------------------------------
On Июнь 7, 2019, 5:21 п.п., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated Июнь 7, 2019, 5:21 п.п.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Benjamin Bannier <bb...@apache.org>.
> On June 7, 2019, 8:55 p.m., Benjamin Bannier wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Line 508 (original), 509 (patched)
> > <https://reviews.apache.org/r/70811/diff/1/?file=2148200#file2148200line510>
> >
> > For non-`__linux-_` cases this silently drops any configuration. Why wouldn't we return an error in that case instead?
>
> Andrei Budnik wrote:
> This cpp-module has inconsistencies with handling of Linux/non-Linux cases. For example, `prepareMounts` and `maskPath` are simply no-ops on non-Linux platforms.
> This patch fixes compilation error. Fixing the whole inconsistency issue in a single place is not a goal here.
Since we are already not consistent, let's return a failure here then instead.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215759
-----------------------------------------------------------
On June 7, 2019, 7:21 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 7:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215759
-----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp
Line 508 (original), 509 (patched)
<https://reviews.apache.org/r/70811/#comment302579>
For non-`__linux-_` cases this silently drops any configuration. Why wouldn't we return an error in that case instead?
- Benjamin Bannier
On June 7, 2019, 7:21 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 7:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70811: Fixed compilation error on Mac OS.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215793
-----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp
Line 508 (original), 509 (patched)
<https://reviews.apache.org/r/70811/#comment302672>
I am 100% with BenB here - silently ignoring seems a ticket for hard to explain / debug problems. Let's please return an `Error` suggesting that this setting was not supported on macOS instead.
- Till Toenshoff
On June 7, 2019, 5:21 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 5:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0
>
>
> Diff: https://reviews.apache.org/r/70811/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>