You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/05 07:26:18 UTC

[GitHub] [skywalking] zshit commented on a change in pull request #5235: support collecting feign params

zshit commented on a change in pull request #5235:
URL: https://github.com/apache/skywalking/pull/5235#discussion_r465527028



##########
File path: apm-sniffer/apm-sdk-plugin/feign-default-http-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/feign/http/v9/DefaultHttpClientInterceptor.java
##########
@@ -81,6 +82,16 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
         Tags.HTTP.METHOD.set(span, request.method());
         Tags.URL.set(span, request.url());
         SpanLayer.asHttp(span);
+        if (FeignPluginConfig.Plugin.Feign.TRACE_PARAMS) {
+            if (request.charset() != null && request.body() != null) {
+                String tagValue = new String(request.body(), request.charset());

Review comment:
       thank you for your advice . I will try to solve it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org