You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/12/05 16:29:21 UTC
[I] [CI][C++] Compilation failures with protoc 29.0.0 [arrow]
pitrou opened a new issue, #44954:
URL: https://github.com/apache/arrow/issues/44954
### Describe the bug, including details regarding any error messages, version, and platform.
The protobuf compiler has started adding [C++ deprecated attributes](https://github.com/protocolbuffers/protobuf/pull/18036) to class and enum declarations.
This in turns breaks our CI builds on macOS, and will probably break other builds later:
https://github.com/apache/arrow/actions/runs/12172205626/job/33950463294
```
FAILED: CMakeFiles/substrait.dir/substrait_ep-generated/substrait/algebra.pb.cc.o
/opt/homebrew/bin/ccache /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DARROW_HAVE_NEON -DPROTOBUF_USE_DLLS -I/Users/runner/work/arrow/arrow/build/cpp/substrait_ep-generated -I/Users/runner/work/arrow/arrow/build/cpp/src -I/Users/runner/work/arrow/arrow/cpp/src -I/Users/runner/work/arrow/arrow/cpp/src/generated -isystem /opt/homebrew/include -fno-aligned-new -Qunused-arguments -fcolor-diagnostics -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wshorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a -g -Werror -O0 -ggdb -g1 -std=c++17 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -Wno-error=shorten-64-to-32 -MD -MT CMakeFiles/substrait.dir/substrait_ep-generated/substrait/algebra.pb.cc.o -MF CMakeFiles/su
bstrait.dir/substrait_ep-generated/substrait/algebra.pb.cc.o.d -o CMakeFiles/substrait.dir/substrait_ep-generated/substrait/algebra.pb.cc.o -c /Users/runner/work/arrow/arrow/build/cpp/substrait_ep-generated/substrait/algebra.pb.cc
In file included from /Users/runner/work/arrow/arrow/build/cpp/substrait_ep-generated/substrait/algebra.pb.cc:6:
/Users/runner/work/arrow/arrow/build/cpp/substrait_ep-generated/substrait/algebra.pb.h:18443:16: error: 'Expression_Enum' is deprecated [-Werror,-Wdeprecated-declarations]
using Enum = Expression_Enum;
^
/Users/runner/work/arrow/arrow/build/cpp/substrait_ep-generated/substrait/algebra.pb.h:7571:9: note: 'Expression_Enum' has been explicitly marked deprecated here
class [[deprecated]] Expression_Enum final
^
```
### Component(s)
C++, Continuous Integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Compilation failures with protoc 29.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #44954:
URL: https://github.com/apache/arrow/issues/44954#issuecomment-2520850548
We will need to find a way to selectively disable those warnings for protobuf-generated files somehow.
Or, worse, we'll have to remove those `[[deprecated]]` attributes with a command-line utility :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Compilation failures with protoc 29.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #44954: [CI][C++] Compilation failures with protoc 29.0.0
URL: https://github.com/apache/arrow/issues/44954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Compilation failures with protoc 29.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44954:
URL: https://github.com/apache/arrow/issues/44954#issuecomment-2524968741
Issue resolved by pull request 44955
https://github.com/apache/arrow/pull/44955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Compilation failures with protoc 29.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #44954:
URL: https://github.com/apache/arrow/issues/44954#issuecomment-2547690826
For the record, protobuf is reverting the offending upstream changes:
https://github.com/protocolbuffers/protobuf/issues/19568#issuecomment-2546959415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org