You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/07/16 09:00:51 UTC

Review Request 12590: More sophisticated hack for post-reviews.py.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12590/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

The hack for post-reviews.py was insufficient. This is a larger hammer.

Basically, in order to run 'post-review' we first 'cherry-pick' all changes between incubator-mesos.git and the current sha we want to create a diff for onto a temporary branch based off of incubator-mesos/master! That way we should only have indexes with references in incubator-mesos.git. *sigh*


Diffs
-----

  support/post-reviews.py 4099d2c2d00ef2e8fac5369153329dd3de0998c1 

Diff: https://reviews.apache.org/r/12590/diff/


Testing
-------

$ post-reviews


Thanks,

Benjamin Hindman


Re: Review Request 12590: More sophisticated hack for post-reviews.py.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12590/#review23311
-----------------------------------------------------------


can you mark this as submitted?

- Vinod Kone


On July 16, 2013, 7 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12590/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 7 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The hack for post-reviews.py was insufficient. This is a larger hammer.
> 
> Basically, in order to run 'post-review' we first 'cherry-pick' all changes between incubator-mesos.git and the current sha we want to create a diff for onto a temporary branch based off of incubator-mesos/master! That way we should only have indexes with references in incubator-mesos.git. *sigh*
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 4099d2c2d00ef2e8fac5369153329dd3de0998c1 
> 
> Diff: https://reviews.apache.org/r/12590/diff/
> 
> 
> Testing
> -------
> 
> $ post-reviews
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>