You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Ted Malaska (JIRA)" <ji...@apache.org> on 2012/09/26 20:17:07 UTC

[jira] [Created] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Ted Malaska created PIG-2933:
--------------------------------

             Summary: HBaseStorage is using setScannerCaching which is deprecated
                 Key: PIG-2933
                 URL: https://issues.apache.org/jira/browse/PIG-2933
             Project: Pig
          Issue Type: Bug
            Reporter: Ted Malaska
            Priority: Minor


HTable.setScannerCaching is deprecated use Scan.setCaching(int)

Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486474#comment-13486474 ] 

Prashant Kommireddi commented on PIG-2933:
------------------------------------------

1. Makes sense
2. I think inner classes ordering on imports is different, it's usually placed below. Let me know if you think otherwise as per Apache pig guidelines. 
                
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prashant Kommireddi updated PIG-2933:
-------------------------------------

    Patch Info: Patch Available
    
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486496#comment-13486496 ] 

Rohini Palaniswamy commented on PIG-2933:
-----------------------------------------

bq. I think inner classes ordering on imports is different, it's usually placed below. Let me know if you think otherwise as per Apache pig guidelines.
  Its just a standard ordering and should work with any IDE. Checked that doing a Ctrl+Shift+O in Eclipse puts Map.Entry immediately after Map. 

+1. Will commit this once I get access. 
                
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933_1.patch, PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486499#comment-13486499 ] 

Prashant Kommireddi commented on PIG-2933:
------------------------------------------

Sounds good, thanks.
                
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933_1.patch, PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohini Palaniswamy resolved PIG-2933.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.12

Committed to trunk. Thanks Prashant
                
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>             Fix For: 0.12
>
>         Attachments: PIG-2933_1.patch, PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485711#comment-13485711 ] 

Rohini Palaniswamy commented on PIG-2933:
-----------------------------------------

Prashant,
   Thanks for the fix. I just have two minor comments. 

   * Can you move the scan.setCaching(caching_); next to scan.setCacheBlocks(false); in initScan()? It will help keeping all the scan settings in a single method. 
   * The patch corrects the order of imports. But Map.Entry is moved after Properties. Can you fix that?
                
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prashant Kommireddi reassigned PIG-2933:
----------------------------------------

    Assignee: Prashant Kommireddi
    
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Graham updated PIG-2933:
-----------------------------

    Labels: hbase  (was: )
    
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Priority: Minor
>              Labels: hbase
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prashant Kommireddi updated PIG-2933:
-------------------------------------

    Attachment: PIG-2933.patch

Smallest patch ever :)
                
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2933) HBaseStorage is using setScannerCaching which is deprecated

Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prashant Kommireddi updated PIG-2933:
-------------------------------------

    Attachment: PIG-2933_1.patch
    
> HBaseStorage is using setScannerCaching which is deprecated
> -----------------------------------------------------------
>
>                 Key: PIG-2933
>                 URL: https://issues.apache.org/jira/browse/PIG-2933
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ted Malaska
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>              Labels: hbase
>         Attachments: PIG-2933_1.patch, PIG-2933.patch
>
>
> HTable.setScannerCaching is deprecated use Scan.setCaching(int)
> Note: I'm on vacation starting tomorrow.  If you want I can fix this next week.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira