You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/01/18 08:49:54 UTC

[GitHub] [incubator-inlong] imvan opened a new pull request #2182: Feature/inlong 2161 Manager support getClusterConfig

imvan opened a new pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182


   ### Title Name: [INLONG-2161][Feature] Manager support getClusterConfig
   
   Manager support getClusterConfig
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature?  yes 
     - If yes, how is the feature documented?  JavaDocs
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] gosonzhang commented on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015359425


   @imvan, Why are there so many code submissions? 
   
   From the feature description, this modified code should be very small, is there no rebase when submitting the code? 
   
   Please rebase the code first, and then submit it, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] wardlican edited a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
wardlican edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015998651


   ![image](https://user-images.githubusercontent.com/95597038/150047691-a79ab07c-870f-4484-957e-3629af0080ca.png)
   
   "result: true" and "errorCode" are not reasonable in the protocol. It is suggested to change them to: "msg" and "code"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan commented on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan commented on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1016133907


   > ![image](https://user-images.githubusercontent.com/95597038/150047691-a79ab07c-870f-4484-957e-3629af0080ca.png)
   > 
   > "result: true" and "errorCode" are not reasonable in the protocol. It is suggested to change them to: "msg" and "code". use return code to judge whether it is successful or not.
   
   Thx @wardlican , very nice suggestion. The fields "result" and "errCode"  has been replaced with "msg" and "code"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan closed pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan closed pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan commented on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan commented on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015369249


   > @imvan, Why are there so many code submissions?
   > 
   > From the feature description, this modified code should be very small, is there no rebase when submitting the code?
   > 
   > Please rebase the code first, and then submit it, thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] wardlican commented on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
wardlican commented on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015998651


   ![image](https://user-images.githubusercontent.com/95597038/150047691-a79ab07c-870f-4484-957e-3629af0080ca.png)
   
   "Result: true" and "errorcode" are not reasonable in the protocol. It is suggested to change them to: "msg" and "code"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan removed a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan removed a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015369249


   > @imvan, Why are there so many code submissions?
   > 
   > From the feature description, this modified code should be very small, is there no rebase when submitting the code?
   > 
   > Please rebase the code first, and then submit it, thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] wardlican edited a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
wardlican edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015998651


   ![image](https://user-images.githubusercontent.com/95597038/150047691-a79ab07c-870f-4484-957e-3629af0080ca.png)
   
   "result: true" and "errorcode" are not reasonable in the protocol. It is suggested to change them to: "msg" and "code"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] wardlican edited a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
wardlican edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015998651


   ![image](https://user-images.githubusercontent.com/95597038/150047691-a79ab07c-870f-4484-957e-3629af0080ca.png)
   
   "result: true" and "errorCode" are not reasonable in the protocol. It is suggested to change them to: "msg" and "code". use return code  to judge whether it is successful or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015397868


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2182](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e91c026) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/58a3f51f1bac4211ae950f8dddce2d61be3e510c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58a3f51) will **increase** coverage by `0.33%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/2182/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2182      +/-   ##
   ============================================
   + Coverage     12.22%   12.55%   +0.33%     
   - Complexity     1154     1201      +47     
   ============================================
     Files           413      417       +4     
     Lines         35243    35735     +492     
     Branches       5544     5590      +46     
   ============================================
   + Hits           4308     4487     +179     
   - Misses        30173    30448     +275     
   - Partials        762      800      +38     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...inlong/tubemq/manager/service/TaskServiceImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtbWFuYWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9tYW5hZ2VyL3NlcnZpY2UvVGFza1NlcnZpY2VJbXBsLmphdmE=) | `3.65% <0.00%> (-4.88%)` | :arrow_down: |
   | [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `51.42% <0.00%> (-4.00%)` | :arrow_down: |
   | [...ong/tubemq/manager/service/ClusterServiceImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtbWFuYWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9tYW5hZ2VyL3NlcnZpY2UvQ2x1c3RlclNlcnZpY2VJbXBsLmphdmE=) | `50.00% <0.00%> (-2.95%)` | :arrow_down: |
   | [...ng/tubemq/server/master/metrics/MasterMetrics.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0cmljcy9NYXN0ZXJNZXRyaWNzLmphdmE=) | `90.00% <0.00%> (-2.50%)` | :arrow_down: |
   | [...emq/server/broker/metrics/BrokerMetricsHolder.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzSG9sZGVyLmphdmE=) | `69.69% <0.00%> (-1.74%)` | :arrow_down: |
   | [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `17.94% <0.00%> (-0.75%)` | :arrow_down: |
   | [...ng/tubemq/server/broker/metrics/BrokerMetrics.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzLmphdmE=) | `97.29% <0.00%> (-0.75%)` | :arrow_down: |
   | [.../tubemq/client/producer/SimpleMessageProducer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9TaW1wbGVNZXNzYWdlUHJvZHVjZXIuamF2YQ==) | `12.50% <0.00%> (-0.57%)` | :arrow_down: |
   | [...emq/server/master/metrics/MasterMetricsHolder.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0cmljcy9NYXN0ZXJNZXRyaWNzSG9sZGVyLmphdmE=) | `86.30% <0.00%> (-0.55%)` | :arrow_down: |
   | [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `44.14% <0.00%> (-0.40%)` | :arrow_down: |
   | ... and [19 more](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [58a3f51...e91c026](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan closed pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan closed pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan edited a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015401813


   > 
   @gosonzhang
   It's a new interface that **Sort Stand-alone** acquire cluster config including id params and sink params.
   Id params is the params of upstream data store such as the topic of kafka and pulsar which Sort Stand-alone consume from.
   While sink params is the dispatch type of Sort Stand-alone Sink,  which determine which kafka or pulsar cluster the produced data send to. hence it's something like kafka zklist, brokerlist,  pulsar serviceUrl, token..
   Due to the diversity of upstream data store type and downstrem sink type, there must be many tables to maintain those params of different type of sources and sinks.
   Most of files are auto generated by Mybatis code generator, such as those xxxMapper.java and xxxMapper.xml
   What we need to care about are those xxxxServiceImpl.java , espacially **SortClusterConfigServiceImpl.java** which is the core logic that how to generate a valid **ClusterConfig**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan commented on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan commented on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015401813


   > 
   
   It's a new interface that **Sort Stand-alone** acquire cluster config including id params and sink params.
   Id params is the params of upstream data store such as the topic of kafka and pulsar which Sort Stand-alone consume from.
   While sink params is the dispatch type of Sort Stand-alone Sink,  which determine which kafka or pulsar cluster the produced data send to. hence it's something like kafka zklist, brokerlist,  pulsar serviceUrl, token..
   Due to the diversity of upstream data store type and downstrem sink type, there must be many tables to maintain those params of different type of sources and sinks.
   Most of files are auto generated by Mybatis code generator, such as those xxxMapper.java and xxxMapper.xml
   What we need to care about are those xxxxServiceImpl.java , espacially **SortClusterConfigServiceImpl.java** which is the core logic that how to generate a valid **ClusterConfig**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] wardlican commented on a change in pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
wardlican commented on a change in pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#discussion_r787293823



##########
File path: inlong-manager/manager-dao/src/main/resources/mappers/TaskIdParamsKafkaEntityMapper.xml
##########
@@ -68,4 +68,138 @@
       topic = #{topic,jdbcType=VARCHAR}
     where id = #{id,jdbcType=INTEGER}
   </update>
+  <resultMap id="BaseResultMap" type="org.apache.inlong.manager.dao.entity.TaskIdParamsKafkaEntity">
+    <id column="id" jdbcType="INTEGER" property="id" />
+    <result column="parent_name" jdbcType="VARCHAR" property="parentName" />
+    <result column="topic" jdbcType="VARCHAR" property="topic" />
+  </resultMap>
+  <sql id="Base_Column_List">
+    id, parent_name, topic
+  </sql>
+  <select id="selectByPrimaryKey" parameterType="java.lang.Integer" resultMap="BaseResultMap">
+    select 
+    <include refid="Base_Column_List" />
+    from task_id_params_kafka
+    where id = #{id,jdbcType=INTEGER}
+  </select>
+  <delete id="deleteByPrimaryKey" parameterType="java.lang.Integer">
+    delete from task_id_params_kafka
+    where id = #{id,jdbcType=INTEGER}
+  </delete>
+  <insert id="insert" parameterType="org.apache.inlong.manager.dao.entity.TaskIdParamsKafkaEntity">
+    insert into task_id_params_kafka (id, parent_name, topic

Review comment:
       need to sort out the format here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015397868


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2182](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6b2a1e) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/58a3f51f1bac4211ae950f8dddce2d61be3e510c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58a3f51) will **increase** coverage by `0.37%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/2182/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2182      +/-   ##
   ============================================
   + Coverage     12.22%   12.59%   +0.37%     
   - Complexity     1154     1210      +56     
   ============================================
     Files           413      417       +4     
     Lines         35243    35735     +492     
     Branches       5544     5590      +46     
   ============================================
   + Hits           4308     4502     +194     
   - Misses        30173    30433     +260     
   - Partials        762      800      +38     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `51.42% <0.00%> (-4.00%)` | :arrow_down: |
   | [...ng/tubemq/server/master/metrics/MasterMetrics.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0cmljcy9NYXN0ZXJNZXRyaWNzLmphdmE=) | `90.00% <0.00%> (-2.50%)` | :arrow_down: |
   | [...emq/server/broker/metrics/BrokerMetricsHolder.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzSG9sZGVyLmphdmE=) | `69.69% <0.00%> (-1.74%)` | :arrow_down: |
   | [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `17.94% <0.00%> (-0.75%)` | :arrow_down: |
   | [...ng/tubemq/server/broker/metrics/BrokerMetrics.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzLmphdmE=) | `97.29% <0.00%> (-0.75%)` | :arrow_down: |
   | [.../tubemq/client/producer/SimpleMessageProducer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9TaW1wbGVNZXNzYWdlUHJvZHVjZXIuamF2YQ==) | `12.50% <0.00%> (-0.57%)` | :arrow_down: |
   | [...emq/server/master/metrics/MasterMetricsHolder.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0cmljcy9NYXN0ZXJNZXRyaWNzSG9sZGVyLmphdmE=) | `86.30% <0.00%> (-0.55%)` | :arrow_down: |
   | [...emq/client/consumer/SimplePushMessageConsumer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9jb25zdW1lci9TaW1wbGVQdXNoTWVzc2FnZUNvbnN1bWVyLmphdmE=) | `8.39% <0.00%> (-0.14%)` | :arrow_down: |
   | [...emq/client/consumer/SimplePullMessageConsumer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9jb25zdW1lci9TaW1wbGVQdWxsTWVzc2FnZUNvbnN1bWVyLmphdmE=) | `2.88% <0.00%> (-0.06%)` | :arrow_down: |
   | [...ng/tubemq/client/consumer/BaseMessageConsumer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9jb25zdW1lci9CYXNlTWVzc2FnZUNvbnN1bWVyLmphdmE=) | `6.20% <0.00%> (-0.05%)` | :arrow_down: |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-inlong/pull/2182/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [58a3f51...d6b2a1e](https://codecov.io/gh/apache/incubator-inlong/pull/2182?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] wardlican commented on a change in pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
wardlican commented on a change in pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#discussion_r787294090



##########
File path: inlong-manager/manager-dao/src/main/resources/mappers/TaskIdParamsPulsarEntityMapper.xml
##########
@@ -0,0 +1,138 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
+<mapper namespace="org.apache.inlong.manager.dao.mapper.TaskIdParamsPulsarEntityMapper">
+  <resultMap id="BaseResultMap" type="org.apache.inlong.manager.dao.entity.TaskIdParamsPulsarEntity">
+    <id column="id" jdbcType="INTEGER" property="id" />
+    <result column="parent_name" jdbcType="VARCHAR" property="parentName" />
+    <result column="topic" jdbcType="VARCHAR" property="topic" />
+  </resultMap>
+  <sql id="Base_Column_List">
+    id, parent_name, topic
+  </sql>
+  <select id="selectByPrimaryKey" parameterType="java.lang.Integer" resultMap="BaseResultMap">
+    select 
+    <include refid="Base_Column_List" />
+    from task_id_params_pulsar
+    where id = #{id,jdbcType=INTEGER}
+  </select>
+  <delete id="deleteByPrimaryKey" parameterType="java.lang.Integer">
+    delete from task_id_params_pulsar
+    where id = #{id,jdbcType=INTEGER}
+  </delete>
+  <insert id="insert" parameterType="org.apache.inlong.manager.dao.entity.TaskIdParamsPulsarEntity">
+    insert into task_id_params_pulsar (id, parent_name, topic

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#discussion_r787283828



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.pojo.sort;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+@Data
+@ApiModel("sort cluster config")

Review comment:
       Avoid to use lombok plugin for readability. Coder need to add getter/setter code when coder want to find usages. Coder want to check source code, then coder must to install lombok plugin.

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortClusterConfig.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class SortClusterConfig implements Serializable {
+    private Integer id;
+
+    private String clusterName;
+
+    private String taskName;
+
+    private static final long serialVersionUID = 1L;

Review comment:
       incorrect serialVersionUID

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/TaskIdParamsKafkaEntity.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class TaskIdParamsKafkaEntity implements Serializable {
+    private Integer id;
+
+    private String parentName;
+
+    private String topic;
+
+    private static final long serialVersionUID = 1L;

Review comment:
       ditto

##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortClusterConfigServiceImpl.java
##########
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.service.core.impl;
+
+import com.google.gson.Gson;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.inlong.manager.common.pojo.sort.SortClusterConfigResponse;
+import org.apache.inlong.manager.common.pojo.sort.SortClusterConfigResponse.SortClusterConfig;
+import org.apache.inlong.manager.common.pojo.sort.SortClusterConfigResponse.SortTaskConfig;
+import org.apache.inlong.manager.dao.entity.TaskConfigEntity;
+import org.apache.inlong.manager.dao.mapper.SortClusterConfigMapper;
+import org.apache.inlong.manager.service.core.SortClusterConfigService;
+import org.apache.inlong.manager.service.core.TaskConfigService;
+import org.apache.inlong.manager.service.core.TaskIdParamsKafkaService;
+import org.apache.inlong.manager.service.core.TaskIdParamsPulsarService;
+import org.apache.inlong.manager.service.core.TaskSinkParamsEsService;
+import org.apache.inlong.manager.service.core.TaskSinkParamsKafkaService;
+import org.apache.inlong.manager.service.core.TaskSinkParamsPulsarService;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Implementation of tSort Cluster config service layer interface.
+ */
+@Service
+@Slf4j
+public class SortClusterConfigServiceImpl implements SortClusterConfigService {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(SortClusterConfigServiceImpl.class);
+
+    @Autowired
+    private SortClusterConfigMapper sortClusterConfigMapper;
+
+    @Autowired
+    private TaskConfigService configService;
+
+    @Autowired
+    private TaskIdParamsPulsarService idParamsPulsarService;
+
+    @Autowired
+    private TaskIdParamsKafkaService idParamsKafkaService;
+
+    @Autowired
+    private TaskSinkParamsEsService sinkParamsEsService;
+
+    @Autowired
+    private TaskSinkParamsKafkaService sinkParamsKafkaService;
+
+    @Autowired
+    private TaskSinkParamsPulsarService sinkParamsPulsarService;
+
+    private static final Gson gson = new Gson();
+
+    @Override
+    public SortClusterConfigResponse get(
+            String clusterName,
+            String md5) {
+        SortClusterConfigResponse response = new SortClusterConfigResponse();
+        response.setResult(true);
+
+        // if the cluster name is invalid, return RESP_CODE_REQ_PARAMS_ERROR
+        if (isErrorReqParams(clusterName)) {
+            LOGGER.error("Empty cluster name, return RESP_CODE_REQ_PARAMS_ERROR");
+            response.setErrCode(SortClusterConfigResponse.RESP_CODE_REQ_PARAMS_ERROR);
+            response.setResult(false);
+            return response;
+        }
+
+        // if the cluster config is null, return RESP_CODE_FAIL
+        SortClusterConfig clusterConfig = this.getClusterConfig(clusterName);
+        if (clusterConfig == null) {
+            LOGGER.error("Cannot find cluster config for cluster {}, return RESP_CODE_FAIL", clusterName);
+            response.setErrCode(SortClusterConfigResponse.RESP_CODE_FAIL);
+            response.setResult(false);
+            return response;
+        }
+
+        // if md5 is the same as last request, return RESP_CODE_NO_UPDATE
+        String jsonClusterConfig = gson.toJson(clusterConfig);

Review comment:
       gson can not sort parameter name, then md5 maybe not  be a stable value.

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/TaskConfigEntity.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class TaskConfigEntity implements Serializable {
+    private Integer id;
+
+    private String name;
+
+    private String type;
+
+    private String inlongGroupId;
+
+    private String inlongStreamId;
+
+    private static final long serialVersionUID = 1L;

Review comment:
       ditto

##########
File path: inlong-manager/manager-dao/src/main/resources/generatorConfig.xml
##########
@@ -212,5 +212,53 @@
                 enableCountByExample="false" enableDeleteByExample="false"
                 enableSelectByExample="false" enableUpdateByExample="false"/>-->
 
+        <!--<table tableName="task_config" domainObjectName="TaskConfigEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>
+
+        <table tableName="task_id_params_kafka" domainObjectName="TaskIdParamsKafkaEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>
+
+        <table tableName="task_id_params_pulsar" domainObjectName="TaskIdParamsPulsarEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>
+
+        <table tableName="task_sink_params_kafka" domainObjectName="TaskSinkParamsKafkaEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>
+
+        <table tableName="task_sink_params_pulsar" domainObjectName="TaskSinkParamsPulsarEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>
+
+        <table tableName="task_sink_params_es" domainObjectName="TaskSinkParamsEsEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>-->

Review comment:
       Invalid code need to be removed.

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/TaskSinkParamsKafkaEntity.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class TaskSinkParamsKafkaEntity implements Serializable {
+    private Integer id;
+
+    private String parentName;
+
+    private String zkList;
+
+    private String brokerList;
+
+    private static final long serialVersionUID = 1L;

Review comment:
       serialVersionUID can be generated by IDE.

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortClusterConfig.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class SortClusterConfig implements Serializable {
+    private Integer id;
+
+    private String clusterName;
+
+    private String taskName;
+
+    private static final long serialVersionUID = 1L;

Review comment:
       static variable is before member variable.

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortStandAloneClusterConfigRequest.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.pojo.sort;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+@Data
+@ApiModel("Sort-StandAlone cluster config request")
+public class SortStandAloneClusterConfigRequest {
+
+    @ApiModelProperty(value = "cluster name")

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] imvan edited a comment on pull request #2182: [INLONG-2161][Feature] Manager support getClusterConfig

Posted by GitBox <gi...@apache.org>.
imvan edited a comment on pull request #2182:
URL: https://github.com/apache/incubator-inlong/pull/2182#issuecomment-1015401813


   > 
   @gosonzhang
   It's a new interface that **Sort Stand-alone** acquire cluster config including id params and sink params.
   Id params is the params of upstream data store such as the topic of kafka and pulsar which Sort Stand-alone consume from.
   While sink params is the dispatch params of Sort Stand-alone Sink, which determine which kafka , pulsar or hive cluster the produced data send to. hence it's something like kafka zklist, brokerlist, pulsar serviceUrl, token.
   Due to the diversity of upstream data store type and downstrem sink type, there must be many tables to maintain those params of different type of sources and sinks.
   Most of files are auto generated by Mybatis code generator, such as those xxxMapper.java and xxxMapper.xml
   What we need to care about are those xxxxServiceImpl.java , espacially **SortClusterConfigServiceImpl.java** which is the core logic that how to generate a valid **ClusterConfig**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org