You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "XuNeo (via GitHub)" <gi...@apache.org> on 2024/02/22 14:31:37 UTC
[PR] cmake: add lvgl cmake support [nuttx-apps]
XuNeo opened a new pull request, #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304
## Summary
Add LVGL cmake support.
## Impact
## Testing
cmake -Bbuild -DBOARD_CONFIG=boards/sim/sim/sim/configs/lvgl_fb -GNinja
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304#discussion_r1499371799
##########
examples/lvgldemo/CMakeLists.txt:
##########
@@ -28,6 +28,8 @@ if(CONFIG_EXAMPLES_LVGLDEMO)
${CONFIG_EXAMPLES_LVGLDEMO_STACKSIZE}
MODULE
${CONFIG_EXAMPLES_LVGLDEMO}
+ DEPENDS
+ lvgl_nuttx
Review Comment:
let's add cmake support when upgrading lvgl to v9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304#discussion_r1500220939
##########
examples/lvgldemo/CMakeLists.txt:
##########
@@ -28,6 +28,8 @@ if(CONFIG_EXAMPLES_LVGLDEMO)
${CONFIG_EXAMPLES_LVGLDEMO_STACKSIZE}
MODULE
${CONFIG_EXAMPLES_LVGLDEMO}
+ DEPENDS
+ lvgl_nuttx
Review Comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "XuNeo (via GitHub)" <gi...@apache.org>.
XuNeo commented on PR #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304#issuecomment-1959642903
There's still one issue for cmake is the CONFIG_INIT_ARGS must be set to empty string for config `lvgl_fb`. The generated config.h is wrong `#define CONFIG_INIT_ARGS \widgets\`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304#discussion_r1499371799
##########
examples/lvgldemo/CMakeLists.txt:
##########
@@ -28,6 +28,8 @@ if(CONFIG_EXAMPLES_LVGLDEMO)
${CONFIG_EXAMPLES_LVGLDEMO_STACKSIZE}
MODULE
${CONFIG_EXAMPLES_LVGLDEMO}
+ DEPENDS
+ lvgl_nuttx
Review Comment:
let's add cmake support after upgrading lvgl to v9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "XuNeo (via GitHub)" <gi...@apache.org>.
XuNeo closed pull request #2304: cmake: add lvgl cmake support
URL: https://github.com/apache/nuttx-apps/pull/2304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: add lvgl cmake support [nuttx-apps]
Posted by "XuNeo (via GitHub)" <gi...@apache.org>.
XuNeo commented on code in PR #2304:
URL: https://github.com/apache/nuttx-apps/pull/2304#discussion_r1499391874
##########
examples/lvgldemo/CMakeLists.txt:
##########
@@ -28,6 +28,8 @@ if(CONFIG_EXAMPLES_LVGLDEMO)
${CONFIG_EXAMPLES_LVGLDEMO_STACKSIZE}
MODULE
${CONFIG_EXAMPLES_LVGLDEMO}
+ DEPENDS
+ lvgl_nuttx
Review Comment:
The idea is to make lvgl v8 working firslty and migrate to v9.0.1 since v9.0.0 is buggy. It should be easier than v8 because lvgl has builtin nuttx support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org