Re: [PR] fix(dashboard): prevent filter dropdown button from disappearing during layout recalculations [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #38193:
URL: https://github.com/apache/superset/pull/38193#discussion_r3126409772


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -625,6 +625,7 @@ const FilterControls: FC<FilterControlsProps> = ({
               : undefined
           }
           forceRender={hasRequiredFirst}
+          alwaysShowDropdownButton={items.length > 0}
           ref={popoverRef}

Review Comment:
   Addressed in d59840d — I kept the button visible to avoid the flicker this PR is trying to fix, but gated the popover on `popoverContent` existence (`open={popoverVisible && !!popoverContent}` + ignoring `onOpenChange` when there's nothing to show) so clicking the trigger can no longer open an empty popover during intermediate layout recalculations. Added a test covering that behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org