[GitHub] [drill] vvysotskyi commented on a change in pull request #1912: DRILL-7324: Final set of "batch count" fixes

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1912: DRILL-7324: Final set of "batch count" fixes
URL: https://github.com/apache/drill/pull/1912#discussion_r352361505
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java
 ##########
 @@ -82,17 +83,27 @@
  *       "sales_city" : BIGINT - nonnullstatcount(sales_city)
  *       "cnt"        : BIGINT - nonnullstatcount(cnt)
  *   .... another map for next stats function ....
+ * </pre>
+ * <p>
+ * Note that the above schema is not a valid Drill record batch: the varous
 
 Review comment:
   If I understand these changes from DRILL-1328 correctly, as a result, we should obtain a map with a single value and its children also should have single values. Looks like this is a bug with specifying wrong row count (perhaps in `buildOutgoingRecordBatch()` method).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services