You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lf...@apache.org on 2006/08/25 00:18:40 UTC
svn commit: r434544 -
/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java
Author: lfrohman
Date: Thu Aug 24 15:18:39 2006
New Revision: 434544
URL: http://svn.apache.org/viewvc?rev=434544&view=rev
Log:
correct minor bug to compareToValidator (no JIRA)
Modified:
myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java
Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java?rev=434544&r1=434543&r2=434544&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java (original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java Thu Aug 24 15:18:39 2006
@@ -321,11 +321,11 @@
}
else if (value instanceof Comparable)
{
- throw new ClassCastException(getClassCastExceptionMessage("value", Comparable.class, value));
+ throw new ClassCastException(getClassCastExceptionMessage(foreignComponent.getId(), Comparable.class, foreignValue));
}
else if (foreignValue instanceof Comparable)
{
- throw new ClassCastException(getClassCastExceptionMessage("foreignValue", Comparable.class, foreignValue));
+ throw new ClassCastException(getClassCastExceptionMessage(uiComponent.getId(), Comparable.class, value));
}
}
Re: svn commit: r434544 - /myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java
Posted by Mike Kienenberger <mk...@gmail.com>.
Ah, I see what you're talking about now.
Good catch. The outputting of the id is a nice improvement as well.
On 8/24/06, lfrohman@apache.org <lf...@apache.org> wrote:
> Author: lfrohman
> Date: Thu Aug 24 15:18:39 2006
> New Revision: 434544
>
> URL: http://svn.apache.org/viewvc?rev=434544&view=rev
> Log:
> correct minor bug to compareToValidator (no JIRA)
>
> Modified:
> myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java
>
> Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java
> URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java?rev=434544&r1=434543&r2=434544&view=diff
> ==============================================================================
> --- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java (original)
> +++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java Thu Aug 24 15:18:39 2006
> @@ -321,11 +321,11 @@
> }
> else if (value instanceof Comparable)
> {
> - throw new ClassCastException(getClassCastExceptionMessage("value", Comparable.class, value));
> + throw new ClassCastException(getClassCastExceptionMessage(foreignComponent.getId(), Comparable.class, foreignValue));
> }
> else if (foreignValue instanceof Comparable)
> {
> - throw new ClassCastException(getClassCastExceptionMessage("foreignValue", Comparable.class, foreignValue));
> + throw new ClassCastException(getClassCastExceptionMessage(uiComponent.getId(), Comparable.class, value));
> }
> }
>
>
>
>