You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/05/09 14:17:03 UTC
[GitHub] [camel] orpiske opened a new pull request, #10037: (chores) Minor cleanups
orpiske opened a new pull request, #10037:
URL: https://github.com/apache/camel/pull/10037
- Avoid setting the context twice (and a type check as well)
- Use final where possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10037: (chores) Minor cleanups
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10037:
URL: https://github.com/apache/camel/pull/10037#issuecomment-1540218181
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #10037: (chores) Minor cleanups
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #10037:
URL: https://github.com/apache/camel/pull/10037#discussion_r1188676102
##########
core/camel-support/src/main/java/org/apache/camel/support/MessageSupport.java:
##########
@@ -204,8 +204,6 @@ public void copyFromWithNewBody(Message that, Object newBody) {
return;
}
- // must copy over CamelContext
- CamelContextAware.trySetCamelContext(that, camelContext);
Review Comment:
The code is already setting up the context in the caller methods (either in the `copy` or in the caller methods prior to this one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10037: (chores) Minor cleanups
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10037:
URL: https://github.com/apache/camel/pull/10037#issuecomment-1540376393
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #10037: (chores) Minor cleanups
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10037:
URL: https://github.com/apache/camel/pull/10037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org