You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/06/22 09:57:45 UTC
[GitHub] [incubator-eventmesh] lrhkobe opened a new pull request, #952: optimize trace module in eventmesh
lrhkobe opened a new pull request, #952:
URL: https://github.com/apache/incubator-eventmesh/pull/952
Fixes ISSUE #946 .
### Motivation
- The current trace implementation is relatively simple ，may not general enough for other specific trace plugin implementations.
### Modifications
- Adjust eventmesh-trace-api，which is based on opentelemetry-api
```
public interface EventMeshTraceService {
void init() throws TraceException;
//extract attr from carrier to context
Context extractFrom(Context context, Map<String, Object> carrier) throws TraceException;
//inject attr from context to carrier
void inject(Context context, Map<String, Object> carrier);
Span createSpan(String spanName, SpanKind spanKind, long startTimestamp, TimeUnit timeUnit,
Context context, boolean isSpanFinishInOtherThread) throws TraceException;
Span createSpan(String spanName, SpanKind spanKind, Context context,
boolean isSpanFinishInOtherThread) throws TraceException;
void shutdown() throws TraceException;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #952: [ISSUE #946] Optimize trace module in eventmesh
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #952:
URL: https://github.com/apache/incubator-eventmesh/pull/952#issuecomment-1164174113
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#952](https://codecov.io/gh/apache/incubator-eventmesh/pull/952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0efe092) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/b8df92753ef4117b2cb05c64b076dc22e8cd95ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8df927) will **decrease** coverage by `0.03%`.
> The diff coverage is `17.14%`.
> :exclamation: Current head 0efe092 differs from pull request most recent head 466b05b. Consider uploading reports for the commit 466b05b to get more accurate results
```diff
@@ Coverage Diff @@
## master #952 +/- ##
===========================================
- Coverage 8.53% 8.49% -0.04%
+ Complexity 529 527 -2
===========================================
Files 353 356 +3
Lines 22747 22753 +6
Branches 2497 2494 -3
===========================================
- Hits 1941 1934 -7
- Misses 20656 20667 +11
- Partials 150 152 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/eventmesh/runtime/boot/EventMeshHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoSFRUUFNlcnZlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...ol/tcp/client/group/ClientSessionGroupMapping.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRTZXNzaW9uR3JvdXBNYXBwaW5nLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mesh/trace/api/common/EventMeshTraceConstants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL2NvbW1vbi9FdmVudE1lc2hUcmFjZUNvbnN0YW50cy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pache/eventmesh/trace/api/common/ProtocolType.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL2NvbW1vbi9Qcm90b2NvbFR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../eventmesh/trace/api/exception/TraceException.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL2V4Y2VwdGlvbi9UcmFjZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/trace/zipkin/ZipkinTraceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2Utemlwa2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2Uvemlwa2luL1ppcGtpblRyYWNlU2VydmljZS5qYXZh) | `64.70% <18.18%> (-29.24%)` | :arrow_down: |
| [...apache/eventmesh/trace/api/TracePluginFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL1RyYWNlUGx1Z2luRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (ø)` | |
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `33.33% <0.00%> (-6.49%)` | :arrow_down: |
| [...sh/client/grpc/consumer/EventMeshGrpcConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uc3VtZXIvRXZlbnRNZXNoR3JwY0NvbnN1bWVyLmphdmE=) | `75.80% <0.00%> (-1.62%)` | :arrow_down: |
| [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b8df927...466b05b](https://codecov.io/gh/apache/incubator-eventmesh/pull/952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #952: [ISSUE #946] Optimize trace module in eventmesh
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #952:
URL: https://github.com/apache/incubator-eventmesh/pull/952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org