You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/30 04:05:09 UTC
[GitHub] [spark] wangyum opened a new pull request #28068: [MINOR][CORE]
Remove two unused variables in LiveListenerBus
wangyum opened a new pull request #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068
### What changes were proposed in this pull request?
This PR removes two unused variables in `LiveListenerBus`. These two variables have moved to [AsyncEventQueue.scala#L67-L71](https://github.com/apache/spark/blob/5b873420b039f61b85bf349443eb830556fab339/core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala#L67-L71)
### Why are the changes needed?
Removes unused variables.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Exist test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28068:
[MINOR][CORE] Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605821857
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28068: [MINOR][CORE]
Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605771563
**[Test build #120570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120570/testReport)** for PR 28068 at commit [`58e08f3`](https://github.com/apache/spark/commit/58e08f367e5a6f24dc9b62dd1f5ba4e73376ca81).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28068: [MINOR][CORE] Remove two
unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605771563
**[Test build #120570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120570/testReport)** for PR 28068 at commit [`58e08f3`](https://github.com/apache/spark/commit/58e08f367e5a6f24dc9b62dd1f5ba4e73376ca81).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28068: [MINOR][CORE]
Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605821873
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120570/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28068:
[MINOR][CORE] Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605771909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25274/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28068: [MINOR][CORE]
Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605771906
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #28068: [MINOR][CORE] Remove
two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28068:
[MINOR][CORE] Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#discussion_r399943804
##########
File path: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala
##########
@@ -54,12 +54,6 @@ private[spark] class LiveListenerBus(conf: SparkConf) {
// Indicate if `stop()` is called
private val stopped = new AtomicBoolean(false)
- /** A counter for dropped events. It will be reset every time we log it. */
- private val droppedEventsCounter = new AtomicLong(0L)
-
- /** When `droppedEventsCounter` was logged last time in milliseconds. */
- @volatile private var lastReportTimestamp = 0L
-
Review comment:
@wangyum, I think we don't usually open a PR to fix a couple of nits. Such changes could be made together when somebody touches here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28068:
[MINOR][CORE] Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#discussion_r400557671
##########
File path: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala
##########
@@ -54,12 +54,6 @@ private[spark] class LiveListenerBus(conf: SparkConf) {
// Indicate if `stop()` is called
private val stopped = new AtomicBoolean(false)
- /** A counter for dropped events. It will be reset every time we log it. */
- private val droppedEventsCounter = new AtomicLong(0L)
-
- /** When `droppedEventsCounter` was logged last time in milliseconds. */
- @volatile private var lastReportTimestamp = 0L
-
Review comment:
+1 for @HyukjinKwon 's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28068: [MINOR][CORE] Remove two
unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605821161
**[Test build #120570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120570/testReport)** for PR 28068 at commit [`58e08f3`](https://github.com/apache/spark/commit/58e08f367e5a6f24dc9b62dd1f5ba4e73376ca81).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28068:
[MINOR][CORE] Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605821873
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120570/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28068:
[MINOR][CORE] Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605771906
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28068: [MINOR][CORE]
Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605821857
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28068: [MINOR][CORE]
Remove two unused variables in LiveListenerBus
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28068: [MINOR][CORE] Remove two unused variables in LiveListenerBus
URL: https://github.com/apache/spark/pull/28068#issuecomment-605771909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25274/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org