You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/01 18:24:40 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7382: Add missing round(), floor(), ceil() to codegen_c.cc backend

tqchen commented on a change in pull request #7382:
URL: https://github.com/apache/tvm/pull/7382#discussion_r568043068



##########
File path: src/target/source/codegen_c.cc
##########
@@ -648,6 +648,21 @@ void CodeGenC::VisitExpr_(const CallNode* op, std::ostream& os) {  // NOLINT(*)
       os << " != ";
       this->PrintExpr(op->args[0], os);
       os << ")";
+    } else if (op->op.as<OpNode>()->name == "tir.round") {

Review comment:
       This is a great point. Additionally, we can cache the operators in the class member, so the original lookup only happens once in initialization time.
   
   See examples in
   https://github.com/apache/tvm/blob/main/src/target/llvm/codegen_llvm.h#L352




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org