You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/27 09:15:14 UTC
[GitHub] [incubator-nuttx] anjianjun opened a new pull request #4237: Xiaomi
anjianjun opened a new pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237
mmcsd_debug.c build error
fix a build error when CONFIG_DEBUG_FS_INFO not defined:
symbol sd2 is not defined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4237: drivers/mmcsd:fix build error of debug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237#issuecomment-887519951
Please reorg your patch:
```
git remote add apache git@github.com:apache/incubator-nuttx.git
git fetch apache
git checkout master
git branch -D xiaomi
git branch --track xiaomi apache/master
git checkout xiaomi
vi ....
git commit
git push -f origin xiaomi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4237: drivers/mmcsd:fix build error of debug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4237: Xiaomi
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237#discussion_r677299911
##########
File path: drivers/mmcsd/mmcsd_debug.c
##########
@@ -72,7 +72,6 @@ void mmcsd_dmpcsd(FAR const uint8_t *csd, uint8_t cardtype)
bool mmc = (cardtype == MMCSD_CARDTYPE_MMC);
#if defined(CONFIG_DEBUG_FS_INFO)
Review comment:
let's remove #if/#endif directly instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4237: drivers/mmcsd:fix build error of debug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237#issuecomment-887377735
Please remove the merge patch from PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4237: drivers/mmcsd:fix build error of debug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237#discussion_r677454493
##########
File path: drivers/mmcsd/mmcsd_debug.c
##########
@@ -166,5 +164,6 @@ void mmcsd_dmpcsd(FAR const uint8_t *csd, uint8_t cardtype)
finfo(" CRC: %02x\n",
sd2 ? SD20_CSD_CRC(csd) : MMCSD_CSD_CRC(csd));
+#endif
Review comment:
remove to avoid the compiler error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org