You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rangadi (via GitHub)" <gi...@apache.org> on 2023/11/20 22:59:30 UTC

Re: [PR] [SPARK-45957] Fix SQL commands on streaming temp view [spark]

rangadi commented on code in PR #43845:
URL: https://github.com/apache/spark/pull/43845#discussion_r1399847139


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2582,9 +2582,14 @@ class SparkConnectPlanner(
               .newBuilder()
               .setData(ByteString.copyFrom(bytes))))
     } else {
-      // Trigger assertExecutedPlanPrepared to ensure post ReadyForExecution before finished
-      // executedPlan is currently called by createMetricsResponse below
-      df.queryExecution.assertExecutedPlanPrepared()
+      if (df.isStreaming) {

Review Comment:
   @jdesjean please review this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org