You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/08/03 11:07:17 UTC

[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #249: 1.1.0-rc1 Updates

stevedlawrence commented on code in PR #249:
URL: https://github.com/apache/daffodil-vscode/pull/249#discussion_r936534181


##########
build/package/.vscodeignore:
##########
@@ -29,3 +29,4 @@
 !src/omega_edit/omega_edit.js
 !src/omega_edit/interface.html
 !src/omega_edit/omega-edit-scala-server*.zip
+!src/language/providers/intellisense/DFDLGeneralFormat.dfdl.xsdf

Review Comment:
   Is the `f` at the end of `.dfdl.xsdf` intentional? The file included with Daffodil just has ` .dfdl.xsd` extension. Is this so it doesn't conflict with what Daffodil distributes or something, or is this just a typo? It looks like the actual file does have the `f` as well as a path in `src/language/dfdl.ts`, so if this is typo we are consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org