You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/13 04:21:00 UTC
[kudu-CR] [subprocess] added test to repro deadlock on logging
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12740
Change subject: [subprocess] added test to repro deadlock on logging
......................................................................
[subprocess] added test to repro deadlock on logging
Added a test to reproduce deadlock in a starting subprocess
while trying to log on failed execve() call.
The test is disabled since it failed. The follow-up
changelist will fix and enable this test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
---
M src/kudu/util/subprocess-test.cc
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12740/1
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12740/3/src/kudu/util/subprocess-test.cc
File src/kudu/util/subprocess-test.cc:
http://gerrit.cloudera.org:8080/#/c/12740/3/src/kudu/util/subprocess-test.cc@375
PS3, Line 375: for (auto i = 0; i < 250; ++i) {
why not have a while (!done) with a atomic<bool> done set by the main thread? ie loop the logger threads until the subprocesses have finished their loop of attempts, and then shut down, instead of this hard-coded 250?
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 16:18:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12740/4/src/kudu/util/subprocess-test.cc
File src/kudu/util/subprocess-test.cc:
http://gerrit.cloudera.org:8080/#/c/12740/4/src/kudu/util/subprocess-test.cc@397
PS4, Line 397: ASSERT_TRUE(s.IsRuntimeError()) << s.ToString();
> Isn't this already done by the SCOPED_CLEANUP?
Indeed. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 19:11:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [subprocess] added test to repro deadlock on logging
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12740
to look at the new patch set (#2).
Change subject: [subprocess] added test to repro deadlock on logging
......................................................................
[subprocess] added test to repro deadlock on logging
Added a test to reproduce deadlock in a starting subprocess
while trying to log on failed execve() call.
The test is disabled since it failed. The follow-up
changelist will fix and enable this test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
---
M src/kudu/util/subprocess-test.cc
1 file changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12740/2
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12740/4/src/kudu/util/subprocess-test.cc
File src/kudu/util/subprocess-test.cc:
http://gerrit.cloudera.org:8080/#/c/12740/4/src/kudu/util/subprocess-test.cc@397
PS4, Line 397: stop_logging = true;
Isn't this already done by the SCOPED_CLEANUP?
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:42:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [subprocess] added test to repro deadlock on logging
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] added test to repro deadlock on logging
......................................................................
Patch Set 1:
(5 comments)
How
http://gerrit.cloudera.org:8080/#/c/12740/1//COMMIT_MSG
Commit Message:
PS1:
How often does it deadlock? I wonder if it'd deadlock more often if the Subprocess was run in a loop for some number of seconds. May only need one logging thread at that point.
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc
File src/kudu/util/subprocess-test.cc:
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@373
PS1, Line 373: LOG(INFO) << Substitute("$0: $1", thread_idx, i);
Should explain why each thread logs and sleeps.
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@385
PS1, Line 385: Subprocess p({ "/nonexistent.file" });
Nit: any particular reason to use an absolute path here? Not that I would expect anyone to have an executable named /nonexistent.file, but if you tried to run it directly in the CWD, it's _definitely_ not there.
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@387
PS1, Line 387: ASSERT_OK(p.Start());
Could maybe simplify with Subprocess::Call? The barrier point would come "earlier" (since the subprocess creation happens inside Call) but I doubt that would matter.
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@388
PS1, Line 388: int wait_status = 0;
Nit: does it need to be initialized?
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 04:27:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12740
to look at the new patch set (#4).
Change subject: [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
[subprocess] test to repro deadlock in Subproces::Run()
Added a test to reproduce deadlock when fork()-ed but not yet
exec()-ed subprocess tries to log on a failed execve() call.
The test is disabled because it fails. The follow-up
changelist will fix the problem and re-enable the test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
---
M src/kudu/util/subprocess-test.cc
1 file changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12740/4
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [subprocess] added test to repro deadlock on logging
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] added test to repro deadlock on logging
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12740/1//COMMIT_MSG
Commit Message:
PS1:
> How often does it deadlock? I wonder if it'd deadlock more often if the Sub
With the code as is, it deadlocked every time I ran it at ve0518 (ran about 100 times or so in DEBUG configuration). I can get a broader stats using dist-test, if needed.
Running Subprocess in a loop is a good idea -- I'll do that.
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc
File src/kudu/util/subprocess-test.cc:
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@373
PS1, Line 373: threads.emplace_back([&barrier, thread_idx] () {
> Should explain why each thread logs and sleeps.
Done
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@385
PS1, Line 385: }
> Nit: any particular reason to use an absolute path here? Not that I would e
Good idea: I switched to using the file in the CWD.
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@387
PS1, Line 387:
> Could maybe simplify with Subprocess::Call? The barrier point would come "e
Done
http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@388
PS1, Line 388: barrier.Wait();
> Nit: does it need to be initialized?
Done
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 05:51:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 19:13:41 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Added a test to reproduce deadlock when fork()-ed but not yet
exec()-ed subprocess tries to log on a failed execve() call.
The test is disabled because it fails. The follow-up
changelist will fix the problem and re-enable the test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Reviewed-on: http://gerrit.cloudera.org:8080/12740
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/subprocess-test.cc
1 file changed, 46 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12740
to look at the new patch set (#3).
Change subject: [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
[subprocess] test to repro deadlock in Subproces::Run()
Added a test to reproduce deadlock when fork()-ed but not yet
exec()-ed subprocess tries to log on a failed execve() call.
The test is disabled because it fails. The follow-up
changelist will fix the problem and re-enable the test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
---
M src/kudu/util/subprocess-test.cc
1 file changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12740/3
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 4:
(1 comment)
Thank you for review!
http://gerrit.cloudera.org:8080/#/c/12740/3/src/kudu/util/subprocess-test.cc
File src/kudu/util/subprocess-test.cc:
http://gerrit.cloudera.org:8080/#/c/12740/3/src/kudu/util/subprocess-test.cc@375
PS3, Line 375: size_t msg_id = 0;
> why not have a while (!done) with a atomic<bool> done set by the main threa
I wanted to clearly see if the sub-process deadlocks and capture the stack if that happens. I added alarm() a bit later. :)
If targeting for successful cases only it's a good idea to introduce the atomic variable, thanks.
Done.
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 17:20:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12740
to look at the new patch set (#5).
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Added a test to reproduce deadlock when fork()-ed but not yet
exec()-ed subprocess tries to log on a failed execve() call.
The test is disabled because it fails. The follow-up
changelist will fix the problem and re-enable the test.
Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
---
M src/kudu/util/subprocess-test.cc
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12740/5
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run()
......................................................................
Patch Set 5: Verified+1
unrelated flake in ConcurrentRebalancersTest.TwoConcurrentRebalancers/1
--
To view, visit http://gerrit.cloudera.org:8080/12740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67
Gerrit-Change-Number: 12740
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 20:31:48 +0000
Gerrit-HasComments: No