You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Ryan Lubke <Ry...@Sun.COM> on 2002/08/28 15:47:00 UTC
[HttpClient][PATCH] Minor enhancement to build process
Hi,
I've added dependency checking for the JAR files specified in the
build.properties for the different compilation targets.
If the dependency isn't satisfied, the build process will fail
before any attempt at compilation is made (NOTE: the dependency
checking targets are leveraged from work done on the Standard
Tag Library project).
If jsse.jar, jcert.jar,jnet.jar, or log4j.jar is not present,
the default compile target will not run.
If junit.jar is not present, the compile.tests target will
not run.
If servlet.jar is not present, the compile.test-webapp target
will not run.
I've also made a modification so that when the compile.test-webapp
target is run, it will create the WAR and EAR files. Saves folks from
having to call the targets after the compilation is complete.
Re: [HttpClient][PATCH] Minor enhancement to build process
Posted by Ryan Lubke <Ry...@Sun.COM>.
Odi,
Thanks. That was some cruft I mistakenly left in from testing that I
didn't notice. I found a few other things now that I'm awake.
Here is a better snap shot of what I was trying to do.
On Fri, 2002-08-30 at 04:40, Ortwin Glück wrote:
> > + <pathelement location="/files/projects/jakarta-commons/httpclient"/>
>
> This looks very specific to your local environment. Can you think of a
> machine independent way?
>
> Odi
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
Re: [HttpClient][PATCH] Minor enhancement to build process
Posted by Ortwin Glück <or...@nose.ch>.
> + <pathelement location="/files/projects/jakarta-commons/httpclient"/>
This looks very specific to your local environment. Can you think of a
machine independent way?
Odi
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient][PATCH] Minor enhancement to build process
Posted by Ryan Lubke <Ry...@Sun.COM>.
On Thu, 2002-08-29 at 09:04, Jeff Dever wrote:
> Ryan Lubke wrote:
>
> > Hi,
> >
> > I've added dependency checking for the JAR files specified in the
> > build.properties for the different compilation targets.
> > If the dependency isn't satisfied, the build process will fail
> > before any attempt at compilation is made (NOTE: the dependency
> > checking targets are leveraged from work done on the Standard
> > Tag Library project).
>
> We are supposed to be moving to Maven for building. build.xml is a maven
> output. I'm not sure how this work would effect that.
I don't think that the build.xml is a maven output, at least not
according to CVS.
>
> >
> >
> > If jsse.jar, jcert.jar,jnet.jar, or log4j.jar is not present,
> > the default compile target will not run.
>
> This is excessively strict. The jsse jars are included in the jdk1.4
> distribution so this should not prevent compilation (did not check if this is
> the case or not). log4j is not a requiremennt for httpclient, but
> commons-logging.jar is.
OK. So the build process will now go through and try to detect if JDK
1.4 is being used. If it is, then the JSSE JAR file dependency check
(which is now in its own target) will not be invoked, and the
compilation process works as expected.
If JDK 1.4 is not being used, then the process will check for the JSSE
JAR files based on the user's build.properties. If found, all is well,
otherwise an error.
I've also removed the check for log4j.
Anyway, take or leave it. It's up to you. I kinda like it at this
point. This definitely takes some of the guess work out of the build
process.
>
> >
> >
> > I've also made a modification so that when the compile.test-webapp
> > target is run, it will create the WAR and EAR files. Saves folks from
> > having to call the targets after the compilation is complete.
>
> I like that!
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
Re: [HttpClient][PATCH] Minor enhancement to build process
Posted by Ryan Lubke <Ry...@Sun.COM>.
On Thu, 2002-08-29 at 09:04, Jeff Dever wrote:
> Ryan Lubke wrote:
>
> > Hi,
> >
> > I've added dependency checking for the JAR files specified in the
> > build.properties for the different compilation targets.
> > If the dependency isn't satisfied, the build process will fail
> > before any attempt at compilation is made (NOTE: the dependency
> > checking targets are leveraged from work done on the Standard
> > Tag Library project).
>
> We are supposed to be moving to Maven for building. build.xml is a maven
> output. I'm not sure how this work would effect that.
>
> >
> >
> > If jsse.jar, jcert.jar,jnet.jar, or log4j.jar is not present,
> > the default compile target will not run.
>
> This is excessively strict. The jsse jars are included in the jdk1.4
> distribution so this should not prevent compilation (did not check if this is
> the case or not). log4j is not a requiremennt for httpclient, but
> commons-logging.jar is.
Good point. An alternative would be a check to see if a particular
class or set of classes is available. If not, then fail before going
though the build process.
As for log4j, I followed the build.properties comments. It was needed
for compilation, but not for runtime.
>
> >
> >
> > I've also made a modification so that when the compile.test-webapp
> > target is run, it will create the WAR and EAR files. Saves folks from
> > having to call the targets after the compilation is complete.
>
> I like that!
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient][PATCH] Minor enhancement to build process
Posted by Jeff Dever <js...@sympatico.ca>.
Ryan Lubke wrote:
> Hi,
>
> I've added dependency checking for the JAR files specified in the
> build.properties for the different compilation targets.
> If the dependency isn't satisfied, the build process will fail
> before any attempt at compilation is made (NOTE: the dependency
> checking targets are leveraged from work done on the Standard
> Tag Library project).
We are supposed to be moving to Maven for building. build.xml is a maven
output. I'm not sure how this work would effect that.
>
>
> If jsse.jar, jcert.jar,jnet.jar, or log4j.jar is not present,
> the default compile target will not run.
This is excessively strict. The jsse jars are included in the jdk1.4
distribution so this should not prevent compilation (did not check if this is
the case or not). log4j is not a requiremennt for httpclient, but
commons-logging.jar is.
>
>
> I've also made a modification so that when the compile.test-webapp
> target is run, it will create the WAR and EAR files. Saves folks from
> having to call the targets after the compilation is complete.
I like that!
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>