You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/09 05:02:00 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request, #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Shoothzj opened a new pull request, #15994:
URL: https://github.com/apache/pulsar/pull/15994
### Motivation
that's a regular update, cassanrda driver 3.6.0 is released in year 2018. Keep update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1151084551
@nicoloboschi Fixed, please take a look again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1152073844
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1151750753
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#discussion_r893593626
##########
pulsar-io/cassandra/pom.xml:
##########
@@ -51,7 +51,7 @@
<dependency>
<groupId>com.datastax.cassandra</groupId>
<artifactId>cassandra-driver-core</artifactId>
- <version>${cassandra-driver-core.version}</version>
+ <version>${cassandra.version}</version>
Review Comment:
ia this needed? we already have it on the dependencyManagement section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #15994:
URL: https://github.com/apache/pulsar/pull/15994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1150810576
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1151844320
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#discussion_r893426823
##########
pom.xml:
##########
@@ -150,7 +150,7 @@ flexible messaging model and an intuitive client API.</description>
<gson.version>2.8.9</gson.version>
<sketches.version>0.8.3</sketches.version>
<hbc-core.version>2.2.0</hbc-core.version>
- <cassandra-driver-core.version>3.6.0</cassandra-driver-core.version>
+ <cassandra-driver-core.version>3.7.2</cassandra-driver-core.version>
Review Comment:
it seems that cassandra-driver-core.version and cassandra.version can be merged into a single property, isn't it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1151984205
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#issuecomment-1150778322
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on a diff in pull request #15994: Bump cassandra driver version from 3.6.0 to 3.11.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #15994:
URL: https://github.com/apache/pulsar/pull/15994#discussion_r893622012
##########
pulsar-io/cassandra/pom.xml:
##########
@@ -51,7 +51,7 @@
<dependency>
<groupId>com.datastax.cassandra</groupId>
<artifactId>cassandra-driver-core</artifactId>
- <version>${cassandra-driver-core.version}</version>
+ <version>${cassandra.version}</version>
Review Comment:
@nicoloboschi nice catch, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org