You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2024/08/12 11:32:38 UTC
[I] Clean the build [jena]
afs opened a new issue, #2638:
URL: https://github.com/apache/jena/issues/2638
### Change
As far as practical, address the warnings raised by the maven build.
* Some warnings are not being suppressed by `@SuppressWarnrings("all")` - it needs the specific warning category
* Need to `@Deprecate` implementations of deprecated interfaces.
Track down logging messages in tests and silence them where they are expected.
See also #2533.
### Are you interested in contributing a pull request for this task?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
Re: [I] Clean the build [jena]
Posted by "Aklakan (via GitHub)" <gi...@apache.org>.
Aklakan commented on issue #2638:
URL: https://github.com/apache/jena/issues/2638#issuecomment-2284034104
I stumbled upon the commit that you re-added `-proc:none` - which conflicted before with https://github.com/apache/jena/pull/2493#issuecomment-2143961015
Perhaps the option could go into a property which defaults to `-proc:none` but which can be overridden on the jmh module?
```xml
<!-- in main pom.xml -->
<properties>
<compiler.proc>-proc:none</compiler.proc>
</properties>```
...
<compilerArgs>
<arg>${compiler.proc}</arg>
</compilerArgs>
```
```xml
<!-- in benchmark pom.xml -->
<properties>
<compiler.proc></compiler.proc>
<!-- if an effectively empty <arg /> causes warning/error, then perhaps a dummy arg (not sure which) could be used -->
</properties>
Alternatively, the benchmark module could have its own compiler plugin section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
Re: [I] Clean the build [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs closed issue #2638: Clean the build
URL: https://github.com/apache/jena/issues/2638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
Re: [I] Clean the build [jena]
Posted by "Aklakan (via GitHub)" <gi...@apache.org>.
Aklakan commented on issue #2638:
URL: https://github.com/apache/jena/issues/2638#issuecomment-2286759448
I suppose `-proc:full` is the future - but overall it seems it might be a pain because of different behavior with past and future Java versions, see: https://inside.java/2024/06/18/quality-heads-up/
> Putting a configuration into the compiler plugin for jena-benchmarks-jmh seems the best choice - it's clearest.
I think so too.
I am not sure about the exact implications with proc:full - in the worst case this module would need a profile for -proc:full and another for without that option. But this could be done as a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
Re: [I] Clean the build [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #2638:
URL: https://github.com/apache/jena/issues/2638#issuecomment-2288132316
https://inside.java/2024/06/18/quality-heads-up/ :
> As of the April 2024 JDK security updates, support for -proc:full has been backported to 17u (17.0.11) and 11u (11.0.23) for both Oracle JDK and OpenJDK distributions. Additionally, Oracle’s 8u release (8u411) also supports -proc:full.
For OpenJDK, no legacy profile is needed, only an up-to-date compiler for Java17.
We could set `-processor*` for `jena-benchmarks-jmh`.
I tried the POM setup in https://www.baeldung.com/java-microbenchmark-harness#start (briefly) but I found that it still needed `-proc` but that should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
Re: [I] Clean the build [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #2638:
URL: https://github.com/apache/jena/issues/2638#issuecomment-2286575871
It really would be helpful to have the build only output what is necessary because when new output occurs, it can get missed. The build output is currently about 6,500 lines.
I'm not sure setting the property will work - when does the substitution happen? The compiler plugin can't be declared in `<build>` in the top POM because then every module gets the compiler plugin.
Putting a configuration into the compiler plugin for `jena-benchmarks-jmh` seems the best choice - it's clearest.
What should the `-proc` setting be `jena-benchmarks-jmh`? `-proc:full` seems to work, `-proc:only` does not.
Other:
Added to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
Re: [I] Clean the build [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #2638:
URL: https://github.com/apache/jena/issues/2638#issuecomment-2564787613
Commits as listed above have been merged to `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org