You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/29 14:34:49 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
wankai123 opened a new pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [X] Update the documentation to include this new feature.
- [X] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
Related to PR #6608
Add argument `namespace`, to avoid the duplicated label value.
Rebuild the relationship between pod and service by labels(selector), since if the pod is not running, we can't get the endpoint IP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.27%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.26% +9.27%
- Complexity 2880 3751 +871
============================================
Files 1793 999 -794
Lines 38409 24894 -13515
Branches 4222 2428 -1794
============================================
- Hits 16130 12763 -3367
+ Misses 21280 10984 -10296
- Partials 999 1147 +148
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.18%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.18% +9.18%
- Complexity 2880 3808 +928
============================================
Files 1793 1796 +3
Lines 38409 38401 -8
Branches 4222 4227 +5
============================================
+ Hits 16130 19655 +3525
+ Misses 21280 17748 -3532
+ Partials 999 998 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.58% <0.00%> (+1.32%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `79.16% <0.00%> (-4.17%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [244 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.19%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.18% +9.19%
- Complexity 2880 3808 +928
============================================
Files 1793 1796 +3
Lines 38409 38401 -8
Branches 4222 4228 +6
============================================
+ Hits 16130 19656 +3526
+ Misses 21280 17748 -3532
+ Partials 999 997 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `79.16% <0.00%> (-4.17%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [244 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.33%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.33% +9.33%
- Complexity 2880 3753 +873
============================================
Files 1793 999 -794
Lines 38409 24894 -13515
Branches 4222 2428 -1794
============================================
- Hits 16130 12779 -3351
+ Misses 21280 10961 -10319
- Partials 999 1154 +155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.48%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.47% +7.48%
- Complexity 2880 3610 +730
============================================
Files 1793 999 -794
Lines 38409 24876 -13533
Branches 4222 2427 -1795
============================================
- Hits 16130 12308 -3822
+ Misses 21280 11489 -9791
- Partials 999 1079 +80
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `6.67%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 48.66% +6.67%
- Complexity 2880 3551 +671
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 12096 -4034
+ Misses 21280 11715 -9565
- Partials 999 1043 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `14.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
- Coverage 41.99% 27.41% -14.58%
+ Complexity 2880 1766 -1114
=============================================
Files 1793 843 -950
Lines 38409 20835 -17574
Branches 4222 1970 -2252
=============================================
- Hits 16130 5712 -10418
+ Misses 21280 14715 -6565
+ Partials 999 408 -591
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.13% <0.00%> (-44.13%)` | `9.00 <0.00> (-46.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1363 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `3.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 38.66% -3.33%
+ Complexity 2880 2474 -406
============================================
Files 1793 843 -950
Lines 38409 21057 -17352
Branches 4222 2013 -2209
============================================
- Hits 16130 8142 -7988
+ Misses 21280 12266 -9014
+ Partials 999 649 -350
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1392 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.32%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.32% +9.32%
- Complexity 2880 3840 +960
============================================
Files 1793 1796 +3
Lines 38409 38403 -6
Branches 4222 4228 +6
============================================
+ Hits 16130 19710 +3580
+ Misses 21280 17698 -3582
+ Partials 999 995 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [250 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `10.72%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 52.72% +10.72%
- Complexity 2880 4030 +1150
=============================================
Files 1793 1796 +3
Lines 38409 38415 +6
Branches 4222 4228 +6
=============================================
+ Hits 16130 20254 +4124
+ Misses 21280 17170 -4110
+ Partials 999 991 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `5.97%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 36.02% -5.98%
+ Complexity 2880 2783 -97
============================================
Files 1793 997 -796
Lines 38409 24599 -13810
Branches 4222 2380 -1842
============================================
- Hits 16130 8861 -7269
+ Misses 21280 14968 -6312
+ Partials 999 770 -229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1301 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `3.88%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 38.11% -3.89%
+ Complexity 2880 2455 -425
============================================
Files 1793 843 -950
Lines 38409 21057 -17352
Branches 4222 2013 -2209
============================================
- Hits 16130 8025 -8105
+ Misses 21280 12408 -8872
+ Partials 999 624 -375
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1392 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `3.88%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 45.88% +3.88%
- Complexity 2880 3409 +529
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 11404 -4726
+ Misses 21280 12477 -8803
+ Partials 999 973 -26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `11.15%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 53.15% +11.15%
- Complexity 2880 4056 +1176
=============================================
Files 1793 1796 +3
Lines 38409 38415 +6
Branches 4222 4228 +6
=============================================
+ Hits 16130 20419 +4289
+ Misses 21280 17005 -4275
+ Partials 999 991 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.82%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.81% +7.82%
- Complexity 2880 3715 +835
============================================
Files 1793 998 -795
Lines 38409 24920 -13489
Branches 4222 2430 -1792
============================================
- Hits 16130 12414 -3716
+ Misses 21280 11444 -9836
- Partials 999 1062 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (+6.51%)` | `62.00 <0.00> (+7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1363 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `1.77%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 40.21% -1.78%
+ Complexity 2880 2561 -319
============================================
Files 1793 843 -950
Lines 38409 21161 -17248
Branches 4222 2021 -2201
============================================
- Hits 16130 8510 -7620
+ Misses 21280 11979 -9301
+ Partials 999 672 -327
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (+6.51%)` | `62.00 <0.00> (+7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1400 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `3.70%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 45.70% +3.70%
- Complexity 2880 3403 +523
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 11359 -4771
+ Misses 21280 12530 -8750
+ Partials 999 965 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `6.42%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 35.57% -6.43%
+ Complexity 2880 2296 -584
============================================
Files 1793 843 -950
Lines 38409 21032 -17377
Branches 4222 2012 -2210
============================================
- Hits 16130 7482 -8648
+ Misses 21280 12983 -8297
+ Partials 999 567 -432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `6.72%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 48.71% +6.72%
- Complexity 2880 3556 +676
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 12108 -4022
+ Misses 21280 11698 -9582
- Partials 999 1048 +49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.48%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.47% +9.48%
- Complexity 2880 3767 +887
============================================
Files 1793 999 -794
Lines 38409 24894 -13515
Branches 4222 2428 -1794
============================================
- Hits 16130 12815 -3315
+ Misses 21280 10917 -10363
- Partials 999 1162 +163
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1359 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.34%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.34% +7.34%
- Complexity 2880 3605 +725
============================================
Files 1793 999 -794
Lines 38409 24876 -13533
Branches 4222 2427 -1795
============================================
- Hits 16130 12274 -3856
+ Misses 21280 11534 -9746
- Partials 999 1068 +69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `6.42%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 35.57% -6.43%
+ Complexity 2880 2296 -584
============================================
Files 1793 843 -950
Lines 38409 21032 -17377
Branches 4222 2012 -2210
============================================
- Hits 16130 7482 -8648
+ Misses 21280 12983 -8297
+ Partials 999 567 -432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `6.68%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 35.30% -6.69%
+ Complexity 2880 2733 -147
============================================
Files 1793 997 -796
Lines 38409 24599 -13810
Branches 4222 2380 -1842
============================================
- Hits 16130 8685 -7445
+ Misses 21280 15144 -6136
+ Partials 999 770 -229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1294 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `6.31%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 48.31% +6.31%
- Complexity 2880 3522 +642
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 12007 -4123
+ Misses 21280 11811 -9469
- Partials 999 1036 +37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.97%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.96% +7.97%
- Complexity 2880 3636 +756
============================================
Files 1793 999 -794
Lines 38409 24876 -13533
Branches 4222 2427 -1795
============================================
- Hits 16130 12430 -3700
+ Misses 21280 11345 -9935
- Partials 999 1101 +102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `10.24%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 52.24% +10.24%
- Complexity 2880 3807 +927
=============================================
Files 1793 999 -794
Lines 38409 24897 -13512
Branches 4222 2428 -1794
=============================================
- Hits 16130 13007 -3123
+ Misses 21280 10717 -10563
- Partials 999 1173 +174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `3.88%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 45.87% +3.88%
- Complexity 2880 3409 +529
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 11403 -4727
+ Misses 21280 12477 -8803
+ Partials 999 974 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `1.87%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 40.11% -1.88%
- Complexity 2880 3082 +202
============================================
Files 1793 998 -795
Lines 38409 24766 -13643
Branches 4222 2418 -1804
============================================
- Hits 16130 9936 -6194
+ Misses 21280 13969 -7311
+ Partials 999 861 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1311 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `11.14%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 53.14% +11.14%
- Complexity 2880 4054 +1174
=============================================
Files 1793 1796 +3
Lines 38409 38415 +6
Branches 4222 4228 +6
=============================================
+ Hits 16130 20415 +4285
+ Misses 21280 17009 -4271
+ Partials 999 991 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603702297
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
I've recorded this as ignored for this pull request. If you change your mind, just comment `@muse-dev unignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.92%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.92% +7.92%
- Complexity 2880 3629 +749
============================================
Files 1793 999 -794
Lines 38409 24876 -13533
Branches 4222 2427 -1795
============================================
- Hits 16130 12419 -3711
+ Misses 21280 11356 -9924
- Partials 999 1101 +102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `10.25%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 52.25% +10.25%
- Complexity 2880 3808 +928
=============================================
Files 1793 999 -794
Lines 38409 24897 -13512
Branches 4222 2428 -1794
=============================================
- Hits 16130 13009 -3121
+ Misses 21280 10716 -10564
- Partials 999 1172 +173
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] TomMD commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
TomMD commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603702205
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
Thanks @wankai123, this is quite clean and a good example for development while improving the tool. I don't know why infer complained but it makes a good test case and eventual regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.60%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.59% +9.60%
- Complexity 2880 3892 +1012
============================================
Files 1793 1796 +3
Lines 38409 38403 -6
Branches 4222 4228 +6
============================================
+ Hits 16130 19815 +3685
+ Misses 21280 17594 -3686
+ Partials 999 994 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.51%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.51% +7.51%
- Complexity 2880 3700 +820
============================================
Files 1793 998 -795
Lines 38409 24920 -13489
Branches 4222 2430 -1792
============================================
- Hits 16130 12339 -3791
+ Misses 21280 11530 -9750
- Partials 999 1051 +52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (+6.51%)` | `62.00 <0.00> (+7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `11.54%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 53.53% +11.54%
- Complexity 2880 4077 +1197
=============================================
Files 1793 1796 +3
Lines 38409 38415 +6
Branches 4222 4228 +6
=============================================
+ Hits 16130 20567 +4437
+ Misses 21280 16857 -4423
+ Partials 999 991 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `16.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
=============================================
+ Coverage 41.99% 58.01% +16.01%
+ Complexity 2880 826 -2054
=============================================
Files 1793 175 -1618
Lines 38409 4282 -34127
Branches 4222 481 -3741
=============================================
- Hits 16130 2484 -13646
+ Misses 21280 1487 -19793
+ Partials 999 311 -688
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | `39.28% <0.00%> (-50.00%)` | `6.00% <0.00%> (-1.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| ... and [1711 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.42%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.42% +7.42%
- Complexity 2880 3694 +814
============================================
Files 1793 998 -795
Lines 38409 24920 -13489
Branches 4222 2430 -1792
============================================
- Hits 16130 12316 -3814
+ Misses 21280 11553 -9727
- Partials 999 1051 +52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (+6.51%)` | `62.00 <0.00> (+7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] TomMD commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
TomMD commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603711138
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
I didn't say ASF complained. I was referring to Muse - the underlying tool that called out this "bug" is named Infer and it is usually quite good. I suspect this case shouldn't have been posted as a bug and actually represents a bug in Infer itself, which I'll try to reproduce on a smaller scale and see if I can open a ticket upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] TomMD commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
TomMD commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603702278
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
@muse-dev ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `6.76%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 48.76% +6.76%
- Complexity 2880 3559 +679
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 12119 -4011
+ Misses 21280 11685 -9595
- Partials 999 1050 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.39%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.38% +9.39%
- Complexity 2880 3849 +969
============================================
Files 1793 1796 +3
Lines 38409 38403 -6
Branches 4222 4228 +6
============================================
+ Hits 16130 19734 +3604
+ Misses 21280 17674 -3606
+ Partials 999 995 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `9.19%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 51.19% +9.19%
- Complexity 2880 3810 +930
============================================
Files 1793 1796 +3
Lines 38409 38401 -8
Branches 4222 4228 +6
============================================
+ Hits 16130 19659 +3529
+ Misses 21280 17745 -3535
+ Partials 999 997 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.96% <0.00%> (+1.70%)` | `56.00 <0.00> (+1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `44.08% <63.63%> (+33.97%)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.85% <66.66%> (+0.54%)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...n/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luVHJhY2VRdWVyeUVzN0RBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [243 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.91%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.91% +7.91%
- Complexity 2880 3627 +747
============================================
Files 1793 999 -794
Lines 38409 24876 -13533
Branches 4222 2427 -1795
============================================
- Hits 16130 12416 -3714
+ Misses 21280 11359 -9921
- Partials 999 1101 +102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603699765
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
ignore，if `service.getSpec()` is null, the process would return in the above code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `4.97%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 46.97% +4.97%
- Complexity 2880 3458 +578
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 11675 -4455
+ Misses 21280 12186 -9094
+ Partials 999 993 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1320 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `6.75%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 48.75% +6.75%
- Complexity 2880 3650 +770
============================================
Files 1793 998 -795
Lines 38409 24920 -13489
Branches 4222 2430 -1792
============================================
- Hits 16130 12149 -3981
+ Misses 21280 11727 -9553
- Partials 999 1044 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (+6.51%)` | `62.00 <0.00> (+7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `4.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 53.99% 49.81% -4.18%
+ Complexity 4126 3715 -411
============================================
Files 1797 998 -799
Lines 38547 24920 -13627
Branches 4231 2430 -1801
============================================
- Hits 20812 12414 -8398
+ Misses 16745 11444 -5301
- Partials 990 1062 +72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (-3.07%)` | `62.00 <0.00> (-1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `3.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 38.95% -3.04%
+ Complexity 2880 2489 -391
============================================
Files 1793 843 -950
Lines 38409 21057 -17352
Branches 4222 2013 -2209
============================================
- Hits 16130 8203 -7927
+ Misses 21280 12205 -9075
+ Partials 999 649 -350
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1397 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603387751
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
*NULL_DEREFERENCE:* object returned by `service.getSpec()` could be null and is dereferenced at line 194.
(at-me [in a reply](https://docs.muse.dev/docs/talk-to-muse/) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603705114
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
> Thanks @wankai123, this is quite clean and a good example for development while improving the tool. I don't know why infer complained but it makes a good test case and eventual regression test.
ASF Infra complained? I am not sure why. Involving this process usually is determined by PMC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `7.71%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 49.71% +7.71%
- Complexity 2880 3620 +740
============================================
Files 1793 999 -794
Lines 38409 24876 -13533
Branches 4222 2427 -1795
============================================
- Hits 16130 12367 -3763
+ Misses 21280 11419 -9861
- Partials 999 1090 +91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.63% <0.00%> (+0.38%)` | `56.00 <0.00> (+1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `7.97%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 34.02% -7.98%
+ Complexity 2880 2548 -332
============================================
Files 1793 966 -827
Lines 38409 23678 -14731
Branches 4222 2292 -1930
============================================
- Hits 16130 8056 -8074
+ Misses 21280 14902 -6378
+ Partials 999 720 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1304 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `6.88%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 48.87% +6.88%
- Complexity 2880 3572 +692
============================================
Files 1793 999 -794
Lines 38409 24854 -13555
Branches 4222 2426 -1796
============================================
- Hits 16130 12148 -3982
+ Misses 21280 11657 -9623
- Partials 999 1049 +50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dc20bbd) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **increase** coverage by `4.63%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
+ Coverage 41.99% 46.63% +4.63%
- Complexity 2880 2894 +14
============================================
Files 1793 844 -949
Lines 38409 21244 -17165
Branches 4222 2028 -2194
============================================
- Hits 16130 9907 -6223
+ Misses 21280 10571 -10709
+ Partials 999 766 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.77% <0.00%> (+6.51%)` | `62.00 <0.00> (+7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...andler/v8/grpc/ManagementServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L2dycGMvTWFuYWdlbWVudFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1420 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#issuecomment-809452291
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=h1) Report
> Merging [#6650](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=desc) (dce2db2) into [master](https://codecov.io/gh/apache/skywalking/commit/0c0a8d439383d8fd98d76a1d9199871b04c62304?el=desc) (0c0a8d4) will **decrease** coverage by `6.34%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dce2db2 differs from pull request most recent head dc20bbd. Consider uploading reports for the commit dc20bbd to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6650 +/- ##
============================================
- Coverage 41.99% 35.65% -6.35%
+ Complexity 2880 2663 -217
============================================
Files 1793 966 -827
Lines 38409 23696 -14713
Branches 4222 2292 -1930
============================================
- Hits 16130 8448 -7682
+ Misses 21280 14489 -6791
+ Partials 999 759 -240
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.10% <0.00%> (-1.15%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <ø> (-92.31%)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-10.12%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6650/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=footer). Last update [0c0a8d4...dc20bbd](https://codecov.io/gh/apache/skywalking/pull/6650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6650: Add arg `namespace` to func `retagByK8sMeta`, rebuild the relationship between pod and service by labels
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6650:
URL: https://github.com/apache/skywalking/pull/6650#discussion_r603687545
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -154,71 +155,76 @@
});
}
- private void addPod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ofNullable(status.getPodIP()).ifPresent(
- ip -> ipPodMap.put(ip, pod))
+ protected void addService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), service)
);
-
recompose();
}
- private void removePod(final V1Pod pod) {
- ofNullable(pod.getStatus()).ifPresent(
- status -> ipPodMap.remove(status.getPodIP())
- );
- ofNullable(pod.getMetadata()).ifPresent(
- metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ protected void removeService(final V1Service service) {
+ ofNullable(service.getMetadata()).ifPresent(
+ metadata -> nameServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace())
);
+ recompose();
}
- private void addEndpoints(final V1Endpoints endpoints) {
- V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
- if (isNull(endpointsMetadata)) {
- log.error("Endpoints metadata is null: {}", endpoints);
- return;
- }
-
- final String namespace = endpointsMetadata.getNamespace();
- final String name = endpointsMetadata.getName();
-
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
- ))
- ));
+ protected void addPod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.put(metadata.getName() + SEPARATOR + metadata.getNamespace(), pod));
recompose();
}
- private void removeEndpoints(final V1Endpoints endpoints) {
- ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
- subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
- address -> ipServiceMap.remove(address.getIp())
- ))
- ));
- recompose();
+ protected void removePod(final V1Pod pod) {
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> namePodMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
+
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(metadata.getName() + SEPARATOR + metadata.getNamespace()));
}
private void recompose() {
- ipPodMap.forEach((ip, pod) -> {
- final String namespaceService = ipServiceMap.get(ip);
- if (isNullOrEmpty(namespaceService)) {
- podServiceMap.remove(ip);
- return;
- }
-
- final V1ObjectMeta podMetadata = pod.getMetadata();
- if (isNull(podMetadata)) {
- log.warn("Pod metadata is null, {}", pod);
- return;
- }
-
- podServiceMap.put(pod.getMetadata().getName(), namespaceService);
+ namePodMap.forEach((podName, pod) -> {
+ nameServiceMap.forEach((serviceName, service) -> {
+ if (isNull(pod.getMetadata()) || isNull(service.getMetadata()) || isNull(service.getSpec())) {
+ return;
+ }
+
+ Map<String, String> selector = service.getSpec().getSelector();
Review comment:
Please check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org