[jira] Updated: (SHINDIG-1395) MutableContent causing lossy content encoding

["Gagandeep Singh (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gagandeep Singh updated SHINDIG-1395:
-------------------------------------

    Comment: was deleted

(was: Please don't worry about reviewing it now. I have discussed this with
anupama and left to watch Inception movie, hence could not make this patch
earlier and get her to look at it. Let us review it locally first. Will send
out the change to dev@ once we are sure.
After chatting with Ziv, it seems this way would be the smallest change and
we can start looking at other calls which might have this bug and start
fixing them later.

Thanks
Gagan


)

> MutableContent causing lossy content encoding
> ---------------------------------------------
>
>                 Key: SHINDIG-1395
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1395
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>            Reporter: Gagandeep Singh
>            Assignee: Gagandeep Singh
>            Priority: Critical
>
> MutableContent.getRawContentBytes and MutableContent.getContent are buggy because they serialize the Document into a utf8 string disregarding the original encoding of the page that is known to the HttpResponse object.
> Here is how it goes wrong for accel servlet:
> AccelServlet.doFetch ->
> DefaulltResponseRewriterRegistry.rewriteHttpResponse ->
> HttpResponseBUilder.create ->
> new HttpResponse ->
> HttpResponseBuilder.getResponse ->
> MutableContent.getRawContentBytes()
> NOTE: This could also be  problem with gadgets. Need to verify.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.