You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "imply-cheddar (via GitHub)" <gi...@apache.org> on 2023/03/09 22:53:10 UTC
[GitHub] [druid] imply-cheddar opened a new pull request, #13914: Add back function signature for compat
imply-cheddar opened a new pull request, #13914:
URL: https://github.com/apache/druid/pull/13914
https://github.com/apache/druid/pull/13904
Added a 4th argument to a commonly-used public static method on `Expressions`. This is commonly used in anything that happens to be planning aggregation from an extension, which means that it risks breaking extensions. This PR re-adds the original signature, deprecated, with comments about how to update to avoid extension breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #13914: Add back function signature for compat
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #13914:
URL: https://github.com/apache/druid/pull/13914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-cheddar commented on pull request #13914: Add back function signature for compat
Posted by "imply-cheddar (via GitHub)" <gi...@apache.org>.
imply-cheddar commented on PR #13914:
URL: https://github.com/apache/druid/pull/13914#issuecomment-1463171904
The previous run of the tests on this failed with 2 types of failures:
Other tests failed due to coverage. I think we can ignore that for now.
The Static Checks failed with
```
Error: processing/src/main/java/org/apache/druid/data/input/MaxSizeSplitHintSpec.java:45 -- Field has one usage but it is not reachable from entry points.
Error: processing/src/main/java/org/apache/druid/data/input/SegmentsSplitHintSpec.java:43 -- Field has one usage but it is not reachable from entry points.
```
Which is very much unrelated to my change. I've added some supressions that hopefully make those disappear, but even if they don't, I think this is safe to merge. Objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org