You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by "rvais (via GitHub)" <gi...@apache.org> on 2023/05/25 10:03:37 UTC

[GitHub] [activemq-artemis] rvais commented on pull request #4403: ARTEMIS-4205 Database Primitive Manager

rvais commented on PR #4403:
URL: https://github.com/apache/activemq-artemis/pull/4403#issuecomment-1562632251

   I like the approach, but it somewhat duplicates already existing locking mechanism. There is for example https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcSharedStateManager.java. It would be good to somewhat unify the approach. The time I have spent on reading the code and my understanding of implemented locking mechanism is limited so it would be worth to spend some more time on this. I will check this out later again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org