[GitHub] [inlong] gosonzhang commented on a diff in pull request #8702: [INLONG-8701][TubeMQ] Fix the master dashboard response always true for some operations

["gosonzhang (via GitHub)" <gi...@apache.org>]

gosonzhang commented on code in PR #8702:
URL: https://github.com/apache/inlong/pull/8702#discussion_r1292910915


##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/web/handler/WebBrokerConfHandler.java:
##########
@@ -1045,19 +1045,27 @@ private boolean getBrokerJsonSetInfo(HttpServletRequest req, boolean isAddOp,
     private StringBuilder buildRetInfo(List<BrokerProcessResult> retInfo,
             StringBuilder sBuffer) {
         int totalCnt = 0;
-        WebParameterUtils.buildSuccessWithDataRetBegin(sBuffer);
+        StringBuilder actionMiddleProxy = new StringBuilder();

Review Comment:
   Can this be done with minimal variable creation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org