You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/11/28 16:40:46 UTC

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #769: add goimports check

little-cui commented on a change in pull request #769:
URL: https://github.com/apache/servicecomb-service-center/pull/769#discussion_r532059238



##########
File path: cmd/scserver/main.go
##########
@@ -17,10 +17,10 @@
 
 package main
 
-import _ "github.com/apache/servicecomb-service-center/server/init"
-import _ "github.com/apache/servicecomb-service-center/server/bootstrap"
 import (
 	"github.com/apache/servicecomb-service-center/server"
+	_ "github.com/apache/servicecomb-service-center/server/bootstrap"

Review comment:
       不可以用这种方式格式化，import是有顺序要求的，参考以下实验
   https://www.reddit.com/r/golang/comments/cubrjk/import_ordering_package_initials_go_fmt_and_so_on/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org