[jira] Commented: (OFBIZ-461) Error when cancelling line items after completing other line items, order adjustment errors - r470162

["Chris Liberty (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/OFBIZ-461?page=comments#action_12450116 ] 
            
Chris Liberty commented on OFBIZ-461:
-------------------------------------

    The problem seems to be that when an order item is cancelled, the entire tax context for the order (item tax and header tax) is blindly destroyed and recalculated, regardless that some order items may already have been invoiced. The guilty party is OrderServices.recalcOrderTax() line 1233. The new relation to OrderAdjustmentBilling exposes the problem by preventing the deletion of OrderAdjustment records which are related to invoices.

    So the question is - what to do about it? The obvious answer is to destroy and recreate only those tax adjustments which haven't yet been billed (aren't related to an OrderAdjustmentBilling record), but that raises the question of what to do with header-level taxes.

    If ProductStore.prorateTaxes is set to N, then all the header-level taxes will have been billed, and recalculating taxes after cancelling an order item would have no effect on header-level taxes.

    Conversely, if ProductStore.prorateTaxes is set to Y, then a portion of header-level taxes will have been billed, and what do we do then? Should we recalculate the taxes normally and then subtract any pro-rated header-level taxes already billed?

> Error when cancelling line items after completing other line items, order adjustment errors - r470162
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-461
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-461
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>         Assigned To: Si Chen
>
> Si,
> Looks like r470162 has caused this problem.
> Create a new order and add two products GZ-1000 and GZ-1001 and then approve the new order.
> Click on "Pack Shipment For Ship Group [00001]" and ensure you only pack and complete the product GZ-1000.
> Viewing the order again you should have an invoice for the part shipment and the outstanding GZ-1001 still in the approved state.
> Click on the "Edit Items" and then "Cancel" the GZ-1001.
> This is the error message:
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Service invocation error (Exception while deleting the following entity: [GenericEntity:OrderAdjustment][orderAdjustmentId,10003(java.lang.String)] (SQL Exception while executing the following:DELETE FROM OFBIZ.ORDER_ADJUSTMENT WHERE ORDER_ADJUSTMENT_ID=? (DELETE on table 'ORDER_ADJUSTMENT' caused a violation of foreign key constraint 'ORDER_ADJBLNG_OA' for key (10003). The statement has been rolled back.)))

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira