You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/11/08 18:24:14 UTC

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1343: PHOENIX-6586 Set NORMALIZATION_ENABLED to false on salted tables

gjacoby126 commented on a change in pull request #1343:
URL: https://github.com/apache/phoenix/pull/1343#discussion_r744984544



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1438,6 +1438,11 @@ private TableDescriptor ensureTableCreated(byte[] physicalTableName, byte[] pare
                         PBoolean.INSTANCE.toObject(newDesc.build().getValue(MetaDataUtil.IS_LOCAL_INDEX_TABLE_PROP_BYTES)))) {
                     newDesc.setRegionSplitPolicyClassName(IndexRegionSplitPolicy.class.getName());
                 }
+                if (props.get(PhoenixDatabaseMetaData.SALT_BUCKETS) != null
+                        && (Integer) (props.get(PhoenixDatabaseMetaData.SALT_BUCKETS)) > 0) {
+                    //Silently overwrites property if it was specified explicitly

Review comment:
       probably want at least a LOG.WARN() here if we're overwriting a property the client explicitly asked for, or alternatively throw an exception




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org