[GitHub] steinaragustli opened a new pull request #262: Cb 13969

[GitBox <gi...@apache.org>]

steinaragustli opened a new pull request #262: Cb 13969
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/262
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS and Android
   
   ### What does this PR do?
   Enables the position of the close/done button on inappbrowser to be swapped with the position of the navigation buttons. See https://issues.apache.org/jira/browse/CB-13969 for screenshots. It also fixes a bug in iOS where the navigation buttons are always hidden, even though the user has 'hidenavigationbuttons=no'. Exactly where the comment "// Filter out Navigation Buttons if user requests so" is located in "src/ios/CDVInAppBrowser.m".
   
   ### What testing has been done on this change?
   I have tested all possible combination of parameters when different buttons are hidden and shown. And everything is consistent with how this should work.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org