You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/05/27 06:10:58 UTC

[GitHub] [samza] bkonold commented on pull request #1367: SAMZA-2530: Split out processing logic from TaskSideInputStorageManager

bkonold commented on pull request #1367:
URL: https://github.com/apache/samza/pull/1367#issuecomment-634450085


   > Nit: General observation, your refactored code seems to use this. in all methods whereas in samza I have often observed that this. is used only in the constructor as the inputs to the constructor maybe the same named vars. Not necessary to address. just curious why you chose this or maybe im wrong about my samza observations :)
   
   I have noticed a mix of both - though it seems that `this.` prefix is used more often in constructors that it is outside them. IMO, it is more readable to have the prefix than to not. However, any team-wide convention should take precedence, though I did not find anything on the OSS guide: https://samza.apache.org/contribute/coding-guide.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org