You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/16 17:52:27 UTC

[GitHub] [trafficcontrol] dpham692 opened a new issue #5161: TP and TO API are validating topology name differently

dpham692 opened a new issue #5161:
URL: https://github.com/apache/trafficcontrol/issues/5161


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   
   -  Traffic Ops
   
   
   ## Current behavior:
   <!-- Describe how the bug manifests -->
   Right now, user can create topologies with special characters like hyphen via Topologies API below.
   `https://{{TO_BASE_URL}}/api/3.0/topologies`
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   TO should not let user create Topologies with special characters like hyphen
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   Do a POST `https://{{TO_BASE_URL}}/api/3.0/topologies` with this payload:
   ```
   {
       "name":"name_hyphen_wrong",
       "description":"test",
       "nodes":
       [{
           "cachegroup":"albany-ny-usa",
           "parent":{"type":"ROOT"},
           "secParent":{"name":"","type":""},
           "parents":[]
       }]
   }
   ```
   ## Anything else:
   <!--
   e.g. stacktraces, related issues, suggestions how to fix (feel free to delete
   this section)
   -->
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on issue #5161: TP and TO API are validating topology name differently

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5161:
URL: https://github.com/apache/trafficcontrol/issues/5161#issuecomment-710315788


   Or should TP's restrictions be relaxed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on issue #5161: TP and TO API are validating topology name differently

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5161:
URL: https://github.com/apache/trafficcontrol/issues/5161#issuecomment-710331746


   I agree w/ @ocket8888 -- TP restrictions should be relaxed instead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp closed issue #5161: TP and TO API are validating topology name differently

Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5161:
URL: https://github.com/apache/trafficcontrol/issues/5161


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org