[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3848: Syslog file rotations number is configurable.

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #3848:
URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646668768



##########
File path: drivers/syslog/Kconfig
##########
@@ -273,23 +273,26 @@ menuconfig SYSLOG_FILE
 
 if SYSLOG_FILE
 
-config SYSLOG_FILE_ROTATE
-	bool "Log file rotate"
-	default n
+config SYSLOG_FILE_ROTATIONS
+	int "Log file rotations"
+	default 0
 	depends on SYSLOG_FILE
 	---help---
-		If enabled, the log file size will be checked before opening.
-		If it is larger than the specified limit it will be "rotated",
-		i.e. the old file will be kept as a backup, and a new empty
-		file will be created.
+		If enabled (set to a non-zero number), the log file size will be
+		checked before opening. If it is larger than the specified limit
+		it will be "rotated", i.e. the old file will be kept as a backup,
+		and a new empty	file will be created.
+		

Review comment:
       It is not common to add empty lines on the help text of Kconfig options.
   Maybe you should remove them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org