[GitHub] merlimat commented on a change in pull request #1866: Binary metadata format

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1866: Binary metadata format
URL: https://github.com/apache/bookkeeper/pull/1866#discussion_r239603231
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerMetadataSerDe.java
 ##########
 @@ -142,15 +163,9 @@ public LedgerMetadataFormat buildProtoFormat(LedgerMetadata metadata) {
             break;
         }
 
-        /** Hack to get around fact that ctime was never versioned correctly */
-        if (LedgerMetadataUtils.shouldStoreCtime(metadata)) {
-            builder.setCtime(metadata.getCtime());
-        }
-
-        if (metadata.hasPassword()) {
-            builder.setDigestType(apiToProtoDigestType(metadata.getDigestType()))
-                .setPassword(ByteString.copyFrom(metadata.getPassword()));
-        }
+        builder.setCtime(metadata.getCtime());
+        builder.setDigestType(apiToProtoDigestType(metadata.getDigestType()))
+            .setPassword(ByteString.copyFrom(metadata.getPassword()));
 
 Review comment:
   If password is empty, we could use `ByteString.EMPTY`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services