[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #729: docs: add makefile && modify develop and deploy docs

[GitBox <gi...@apache.org>]

nic-chen commented on a change in pull request #729:
URL: https://github.com/apache/apisix-dashboard/pull/729#discussion_r519512850



##########
File path: Makefile
##########
@@ -17,26 +17,68 @@
 
 SHELL := /bin/bash -o pipefail
 UNAME ?= $(shell uname)
+YARN_EXEC ?= $(shell which yarn)
+GO_EXEC ?= $(shell which go)
 
-### help:             Show Makefile rules
+export GO111MODULE=on
+
+### help:		Show Makefile rules
 .PHONY: help
 help:
 	@echo Makefile rules:
 	@echo
 	@grep -E '^### [-A-Za-z0-9_]+:' Makefile | sed 's/###/   /'
 
-export GO111MODULE=on
 
-### license-check:    Check apisix-dashboard source codes for Apache License
-.PHONY: license-check
-license-check:
-ifeq ("$(wildcard .actions/openwhisk-utilities/scancode/scanCode.py)", "")
-	git clone https://github.com/apache/openwhisk-utilities.git .actions/openwhisk-utilities
-	cp .actions/ASF* .actions/openwhisk-utilities/scancode/
+### build:		build dashboard, it contains web and manager-api
+.PHONY: build
+build: web-default api-default
+	api/build.sh; \
+	cd /web; \
+	yarn install; \
+	yarn build
+
+
+### run:		run dashboard, it contains web and manager-api
+.PHONY: run
+run:
+	api/run.sh &

Review comment:
       I thinkwe should run source code here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org