You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 13:46:03 UTC
[GitHub] [arrow] vibhatha opened a new pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs [WIP]
vibhatha opened a new pull request #11838:
URL: https://github.com/apache/arrow/pull/11838
In this draft PR, the docstrings were updated and referred to the wikipedia definitions: https://en.wikipedia.org/wiki/Rounding#Types_of_rounding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984951655
Benchmark runs are scheduled for baseline = a8ed77ef1d517e29675465e4c623085d3eb29e7d and contender = 28e9bac8f04745e31de5cb16d2ab65eec3929410. 28e9bac8f04745e31de5cb16d2ab65eec3929410 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b52df39472a64c38a90a10081e01b2bc...a5f5149fe3ca4b29a753cbf7d38b63dd/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3dfd185850ef40a8b022d8c400429d8d...a62b457e466640359fb565e8ac23af9a/)
[Finished :arrow_down:0.4% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/54afa061f07741d1b7960828b45ddb9a...f8f6d44d820240159bf8b45bec65a46c/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#discussion_r761236865
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -57,19 +57,19 @@ class ARROW_EXPORT ElementWiseAggregateOptions : public FunctionOptions {
enum class RoundMode : int8_t {
/// Round to nearest integer less than or equal in magnitude (aka "floor")
DOWN,
- /// Round to nearest integer greater than or equal in magnitude (aka "ceil")
+ /// Round to nearest integer greater than or equal in magnitude (aka "ceiling")
Review comment:
Hmm, "trunc" and "ceil" are common API names for this, for example [in C](https://pubs.opengroup.org/onlinepubs/9699919799/functions/ceil.html), [Python](https://docs.python.org/3/library/math.html#math.ceil) or [Rust](https://doc.rust-lang.org/std/primitive.f64.html#method.ceil), so perhaps keep those names here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
vibhatha commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984653803
> Thanks! Would you like to undraft this? (edit: and remove the [WIP])
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #11838:
URL: https://github.com/apache/arrow/pull/11838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
vibhatha commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984890179
> @vibhatha Can you fix the lint failures? This can normally be done using `archery lint --cpplint --fix` once you have installed [Archery](https://arrow.apache.org/docs/developers/archery.html).
I updated the PR. CI in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984951655
Benchmark runs are scheduled for baseline = a8ed77ef1d517e29675465e4c623085d3eb29e7d and contender = 28e9bac8f04745e31de5cb16d2ab65eec3929410. 28e9bac8f04745e31de5cb16d2ab65eec3929410 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b52df39472a64c38a90a10081e01b2bc...a5f5149fe3ca4b29a753cbf7d38b63dd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3dfd185850ef40a8b022d8c400429d8d...a62b457e466640359fb565e8ac23af9a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/54afa061f07741d1b7960828b45ddb9a...f8f6d44d820240159bf8b45bec65a46c/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984950873
Thanks. The RTools failure appears to be a timeout, the AppVeyor test appears to be S3 tests flaking (ARROW-13957)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a change in pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
vibhatha commented on a change in pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#discussion_r761290031
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -57,19 +57,19 @@ class ARROW_EXPORT ElementWiseAggregateOptions : public FunctionOptions {
enum class RoundMode : int8_t {
/// Round to nearest integer less than or equal in magnitude (aka "floor")
DOWN,
- /// Round to nearest integer greater than or equal in magnitude (aka "ceil")
+ /// Round to nearest integer greater than or equal in magnitude (aka "ceiling")
Review comment:
Sure, I will make those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
vibhatha commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984814991
> Sorry, do you want to rebase/force-push to get CI to trigger again? (It skips everything when you have "WIP" in the PR title)
Sure I will make one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984706242
Sorry, do you want to rebase/force-push to get CI to trigger again? (It skips everything when you have "WIP" in the PR title)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984951655
Benchmark runs are scheduled for baseline = a8ed77ef1d517e29675465e4c623085d3eb29e7d and contender = 28e9bac8f04745e31de5cb16d2ab65eec3929410. 28e9bac8f04745e31de5cb16d2ab65eec3929410 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b52df39472a64c38a90a10081e01b2bc...a5f5149fe3ca4b29a753cbf7d38b63dd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3dfd185850ef40a8b022d8c400429d8d...a62b457e466640359fb565e8ac23af9a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/54afa061f07741d1b7960828b45ddb9a...f8f6d44d820240159bf8b45bec65a46c/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984951655
Benchmark runs are scheduled for baseline = a8ed77ef1d517e29675465e4c623085d3eb29e7d and contender = 28e9bac8f04745e31de5cb16d2ab65eec3929410. 28e9bac8f04745e31de5cb16d2ab65eec3929410 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b52df39472a64c38a90a10081e01b2bc...a5f5149fe3ca4b29a753cbf7d38b63dd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3dfd185850ef40a8b022d8c400429d8d...a62b457e466640359fb565e8ac23af9a/)
[Finished :arrow_down:0.4% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/54afa061f07741d1b7960828b45ddb9a...f8f6d44d820240159bf8b45bec65a46c/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984641738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#issuecomment-984826690
@vibhatha Can you fix the lint failures? This can normally be done using `archery lint --cpplint --fix` once you have installed [Archery](https://arrow.apache.org/docs/developers/archery.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org